chore: clarify coop-close wording

Author: ovitrif

app/src/main/java/to/bitkit/usecases/DeriveBalanceStateUseCase.kt

@@ -45,14 +45,14 @@ class DeriveBalanceStateUseCase @Inject constructor(
 
             val toSavingsAmount = getTransferToSavingsSats(activeTransfers, channels, balanceDetails)
             val coopCloseSavingsSats = getCoopCloseTransferSats(activeTransfers, channels, balanceDetails)
-            val orphanCoopCloseSats = getOrphanCoopCloseSats(activeTransfers, channels, balanceDetails)
+            val lingeringCoopCloseSats = getLingeringCoopCloseSats(activeTransfers, channels, balanceDetails)
             val toSpendingAmount = paidOrdersSats.safe() + pendingChannelsSats.safe()
 
             val totalOnchainSats = balanceDetails.totalOnchainBalanceSats
             val channelFundableBalance = getMaxChannelFundableAmount(lightningRepo.getChannelFundableBalance())
             val afterPendingChannels = balanceDetails.totalLightningBalanceSats.safe() - pendingChannelsSats.safe()
             val afterClosingChannels = afterPendingChannels.safe() - toSavingsAmount.safe()
-            val totalLightningSats = afterClosingChannels.safe() - orphanCoopCloseSats.safe()
+            val totalLightningSats = afterClosingChannels.safe() - lingeringCoopCloseSats.safe()
 
             val balanceState = BalanceState(
                 totalOnchainSats = totalOnchainSats,
@@ -160,7 +160,7 @@ class DeriveBalanceStateUseCase @Inject constructor(
         return amount
     }
 
-    private suspend fun getOrphanCoopCloseSats(
+    private suspend fun getLingeringCoopCloseSats(
         transfers: List<TransferEntity>,
         channels: List<ChannelDetails>,
         balanceDetails: BalanceDetails,
@@ -175,11 +175,11 @@ class DeriveBalanceStateUseCase @Inject constructor(
         val claimableBalances = balanceDetails.lightningBalances
             .filterIsInstance<LightningBalance.ClaimableAwaitingConfirmations>()
         for (balance in claimableBalances) {
-            val isOrphanCoopClose = balance.source == BalanceSource.COOP_CLOSE &&
+            val isLingeringCoopClose = balance.source == BalanceSource.COOP_CLOSE &&
                 balance.channelId !in channelIds &&
                 balance.channelId !in transferChannelIds
 
-            if (isOrphanCoopClose) {
+            if (isLingeringCoopClose) {
                 amount = amount.safe() + balance.amountSatoshis.safe()
             }
         }

app/src/test/java/to/bitkit/usecases/DeriveBalanceStateUseCaseTest.kt

@@ -401,18 +401,18 @@ class DeriveBalanceStateUseCaseTest : BaseUnitTest() {
     }
 
     @Test
-    fun `should subtract orphan coop close balance from lightning while keeping new channel balance`() = test {
+    fun `should subtract lingering coop close claimable from lightning while keeping new channel balance`() = test {
         val closedChannelId = "closed-channel-id"
         val newChannelId = "new-channel-id"
         val closedChannelSats = 1_531_123uL
         val newChannelSats = 62_158uL
-        val orphanClosingBalance = newClosingChannelBalance(closedChannelId, closedChannelSats)
+        val lingeringClosingBalance = newClosingChannelBalance(closedChannelId, closedChannelSats)
         val newChannelBalance = newChannelBalance(newChannelId, newChannelSats)
 
         val balance = newBalanceDetails().copy(
             totalOnchainBalanceSats = closedChannelSats,
             totalLightningBalanceSats = 1_593_281uL,
-            lightningBalances = listOf(orphanClosingBalance, newChannelBalance),
+            lightningBalances = listOf(lingeringClosingBalance, newChannelBalance),
         )
         whenever(lightningRepo.getBalancesAsync()).thenReturn(Result.success(balance))
 
@@ -435,7 +435,7 @@ class DeriveBalanceStateUseCaseTest : BaseUnitTest() {
     }
 
     @Test
-    fun `should not subtract orphan non coop close balance from lightning`() = test {
+    fun `should keep non coop close claimable in lightning`() = test {
         val channelId = "force-closed-channel-id"
         val amountSats = 40_000uL
         val closingChannelBalance = newClosingChannelBalance(