fix: cjit notification race condition

Author: jvsena42

app/src/main/java/to/bitkit/fcm/WakeNodeWorker.kt

@@ -236,6 +236,15 @@ class WakeNodeWorker @AssistedInject constructor(
             return
         }
 
+        // The in-app UI or foreground service owns this event: it records the activity (via the same
+        // insertActivityFromCjit dedup) and shows the richer notification/sheet. Defer entirely —
+        // do NOT insert here, or we'd win the dedup race and silence the in-process handler.
+        if (isHandledInProcess()) {
+            Logger.debug("Skipping CJIT notification: handled in-process", context = TAG)
+            bestAttemptContent = null
+            return
+        }
+
         // A duplicate channel ready event for an already recorded CJIT receive must not notify again
         val inserted = activityRepo.insertActivityFromCjit(cjitEntry = cjitEntry, channel = channel)
             .getOrDefault(false)
@@ -255,13 +264,6 @@ class WakeNodeWorker @AssistedInject constructor(
             )
         )
 
-        // The in-app UI or foreground service shows a richer notification for this event; avoid duplicating it
-        if (isHandledInProcess()) {
-            Logger.debug("Skipping CJIT notification: handled in-process", context = TAG)
-            bestAttemptContent = null
-            return
-        }
-
         bestAttemptContent = receivedNotificationContent.build(sats.toLong())
     }
 

app/src/test/java/to/bitkit/fcm/WakeNodeWorkerTest.kt

@@ -123,8 +123,9 @@ class WakeNodeWorkerTest : BaseUnitTest() {
 
         assertEquals(ListenableWorker.Result.success(), result)
         assertNull(findNotificationByTitle(receivedTitle), "Deduped when the foreground service handles it")
-        // Activity is still recorded so the receive is not lost
-        verify(activityRepo).insertActivityFromCjit(any(), any())
+        // Defers entirely: the in-process handler owns the insert, so the worker must not win the dedup race
+        verify(activityRepo, never()).insertActivityFromCjit(any(), any())
+        verify(cacheStore, never()).setBackgroundReceive(any())
     }
 
     @Test
@@ -152,7 +153,9 @@ class WakeNodeWorkerTest : BaseUnitTest() {
 
         assertEquals(ListenableWorker.Result.success(), result)
         assertNull(findNotificationByTitle(receivedTitle), "Notification is deduped when the in-app UI handles it")
-        verify(activityRepo).insertActivityFromCjit(any(), any())
+        // Defers entirely: the in-app handler owns the insert, so the worker must not win the dedup race
+        verify(activityRepo, never()).insertActivityFromCjit(any(), any())
+        verify(cacheStore, never()).setBackgroundReceive(any())
     }
 
     @Test