fix: encode paykit bip21 invoice

Author: ben-kaufman

app/src/main/java/to/bitkit/repositories/PublicPaykitRepo.kt

@@ -21,6 +21,7 @@ import to.bitkit.models.toLdkNetwork
 import to.bitkit.services.CoreService
 import to.bitkit.utils.AppError
 import to.bitkit.utils.NetworkValidationHelper
+import to.bitkit.utils.encodeToUrl
 import java.util.Locale
 import javax.inject.Inject
 import javax.inject.Singleton
@@ -102,7 +103,7 @@ class PublicPaykitRepo @Inject constructor(
             val onchain = sortedEndpoints.firstOrNull { it.methodId.isOnchain }
 
             if (lightning != null && onchain != null) {
-                return "bitcoin:${onchain.value}?lightning=${lightning.value}"
+                return "bitcoin:${onchain.value}?lightning=${lightning.value.encodeToUrl()}"
             }
 
             return sortedEndpoints.firstOrNull()?.paymentRequest.orEmpty()

app/src/test/java/to/bitkit/repositories/PublicPaykitRepoTest.kt

@@ -315,6 +315,18 @@ class PublicPaykitRepoTest : BaseUnitTest() {
         assertEquals("bitcoin:bc1ptest?lightning=lnbc1test", request)
     }
 
+    @Test
+    fun `paymentRequest encodes bolt11 query parameter`() {
+        val request = PublicPaykitRepo.paymentRequest(
+            listOf(
+                endpoint(MethodId.Bolt11, "lnbc1test&label"),
+                endpoint(MethodId.P2tr, "bc1ptest"),
+            ),
+        )
+
+        assertEquals("bitcoin:bc1ptest?lightning=lnbc1test%26label", request)
+    }
+
     @Test
     fun `paymentRequest prefers taproot among multiple onchain endpoints`() {
         val request = PublicPaykitRepo.paymentRequest(