fix: polish public contact payments

Author: ben-kaufman

app/src/main/java/to/bitkit/ext/Activities.kt

@@ -66,6 +66,12 @@ fun Activity.isTransfer() = this is Activity.Onchain && this.v1.isTransfer
 
 fun Activity.doesExist() = this is Activity.Onchain && this.v1.doesExist
 
+fun Activity.isReplacedSentTransaction(txIdsInBoostTxIds: Set<String>): Boolean =
+    this is Activity.Onchain &&
+        !v1.doesExist &&
+        v1.txType == PaymentType.SENT &&
+        v1.txId in txIdsInBoostTxIds
+
 fun Activity.paymentState(): PaymentState? = when (this) {
     is Activity.Lightning -> this.v1.status
     is Activity.Onchain -> null

app/src/main/java/to/bitkit/repositories/ActivityRepo.kt

@@ -36,6 +36,7 @@ import to.bitkit.di.BgDispatcher
 import to.bitkit.di.IoDispatcher
 import to.bitkit.ext.amountOnClose
 import to.bitkit.ext.contact
+import to.bitkit.ext.isReplacedSentTransaction
 import to.bitkit.ext.matchesPaymentId
 import to.bitkit.ext.nowMillis
 import to.bitkit.ext.nowTimestamp
@@ -345,10 +346,13 @@ class ActivityRepo @Inject constructor(
     suspend fun contactActivities(publicKey: String): Result<List<Activity>> = withContext(ioDispatcher) {
         runCatching {
             val normalizedKey = PubkyPublicKeyFormat.normalized(publicKey) ?: publicKey
+            val txIdsInBoostTxIds = getTxIdsInBoostTxIds()
             getActivities(
                 filter = ActivityFilter.ALL,
                 sortDirection = SortDirection.DESC,
-            ).getOrThrow().filter { PubkyPublicKeyFormat.matches(it.contact(), normalizedKey) }
+            ).getOrThrow()
+                .filterNot { it.isReplacedSentTransaction(txIdsInBoostTxIds) }
+                .filter { PubkyPublicKeyFormat.matches(it.contact(), normalizedKey) }
         }.onFailure {
             Logger.error("Failed to load contact activities for '$publicKey'", it, context = TAG)
         }

app/src/main/java/to/bitkit/services/CoreService.kt

@@ -1021,7 +1021,8 @@ class ActivityService(
         val updatedActivity = replacementActivity.copy(
             boostTxIds = replacementActivity.boostTxIds + txid,
             isBoosted = true,
-            updatedAt = System.currentTimeMillis().toULong() / 1000u
+            contact = replacementActivity.contact ?: replacedActivity?.contact,
+            updatedAt = System.currentTimeMillis().toULong() / 1000u,
         )
         updateActivity(replacementActivity.id, Activity.Onchain(updatedActivity))
 

app/src/main/java/to/bitkit/ui/ContentView.kt

@@ -1005,6 +1005,7 @@ private fun NavGraphBuilder.contacts(
             onBackClick = { navController.popBackStack() },
             onContactSaved = { navController.popBackStack() },
             onPayContact = { paymentRequest, publicKey ->
+                navController.popBackStack()
                 appViewModel.openContactPayment(paymentRequest, publicKey)
             },
         )

app/src/main/java/to/bitkit/viewmodels/ActivityListViewModel.kt

@@ -26,6 +26,7 @@ import kotlinx.coroutines.flow.stateIn
 import kotlinx.coroutines.flow.update
 import kotlinx.coroutines.launch
 import to.bitkit.di.BgDispatcher
+import to.bitkit.ext.isReplacedSentTransaction
 import to.bitkit.ext.isTransfer
 import to.bitkit.models.PubkyProfile
 import to.bitkit.repositories.ActivityRepo
@@ -146,19 +147,7 @@ class ActivityListViewModel @Inject constructor(
 
     private suspend fun filterOutReplacedSentTransactions(activities: List<Activity>): List<Activity> {
         val txIdsInBoostTxIds = activityRepo.getTxIdsInBoostTxIds()
-
-        return activities.filter {
-            if (it is Activity.Onchain) {
-                val onchain = it.v1
-                if (!onchain.doesExist &&
-                    onchain.txType == PaymentType.SENT &&
-                    txIdsInBoostTxIds.contains(onchain.txId)
-                ) {
-                    return@filter false
-                }
-            }
-            true
-        }
+        return activities.filterNot { it.isReplacedSentTransaction(txIdsInBoostTxIds) }
     }
 
     fun updateAvailableTags() {

app/src/main/java/to/bitkit/viewmodels/AppViewModel.kt

@@ -1137,7 +1137,7 @@ class AppViewModel @Inject constructor(
     }
 
     private fun onAddressContinue(data: String) {
-        launchScan(source = ScanSource.ADDRESS_CONTINUE, data = data)
+        launchScan(source = ScanSource.ADDRESS_CONTINUE, data = data, routePubkyKeys = true)
     }
 
     private suspend fun onAmountChange(amount: ULong) {

app/src/test/java/to/bitkit/repositories/ActivityRepoTest.kt

@@ -87,6 +87,7 @@ class ActivityRepoTest : BaseUnitTest() {
         confirmTimestamp: ULong? = baseOnchainActivity.confirmTimestamp,
         channelId: String? = baseOnchainActivity.channelId,
         transferTxId: String? = baseOnchainActivity.transferTxId,
+        contact: String? = baseOnchainActivity.contact,
         createdAt: ULong? = baseOnchainActivity.createdAt,
         updatedAt: ULong? = baseOnchainActivity.updatedAt,
     ): Activity.Onchain {
@@ -107,6 +108,7 @@ class ActivityRepoTest : BaseUnitTest() {
                 confirmTimestamp = confirmTimestamp,
                 channelId = channelId,
                 transferTxId = transferTxId,
+                contact = contact,
                 createdAt = createdAt,
                 updatedAt = updatedAt
             )
@@ -267,6 +269,41 @@ class ActivityRepoTest : BaseUnitTest() {
         assertNull(result.getOrThrow())
     }
 
+    @Test
+    fun `contactActivities filters replaced sent transaction`() = test {
+        val contactPublicKey = "pubky3rsduhcxpw74snwyct86m38c63j3pq8x4ycqikxg64roik8yw5xg"
+        val replacedTxId = "replaced_tx_id"
+        val replacedActivity = createOnchainActivity(
+            id = "replaced_activity_id",
+            txId = replacedTxId,
+            doesExist = false,
+            contact = contactPublicKey,
+        )
+        val replacementActivity = createOnchainActivity(
+            id = "replacement_activity_id",
+            txId = "replacement_tx_id",
+            boostTxIds = listOf(replacedTxId),
+            contact = contactPublicKey,
+        )
+        whenever(coreService.activity.getTxIdsInBoostTxIds()).thenReturn(setOf(replacedTxId))
+        whenever(
+            coreService.activity.get(
+                filter = ActivityFilter.ALL,
+                txType = null,
+                tags = null,
+                search = null,
+                minDate = null,
+                maxDate = null,
+                limit = null,
+                sortDirection = SortDirection.DESC,
+            )
+        ).thenReturn(listOf(replacedActivity, replacementActivity))
+
+        val result = sut.contactActivities(contactPublicKey)
+
+        assertEquals(listOf(replacementActivity), result.getOrThrow())
+    }
+
     @Test
     fun `updateActivity updates successfully when not deleted`() = test {
         val activityId = "activity123"

app/src/test/java/to/bitkit/viewmodels/AppViewModelSendFlowTest.kt

@@ -1,6 +1,7 @@
 package to.bitkit.viewmodels
 
 import android.content.Context
+import app.cash.turbine.test
 import com.synonym.bitkitcore.LightningInvoice
 import com.synonym.bitkitcore.NetworkType
 import com.synonym.bitkitcore.Scanner
@@ -50,6 +51,7 @@ import to.bitkit.services.AppUpdaterService
 import to.bitkit.services.CoreService
 import to.bitkit.services.MigrationService
 import to.bitkit.test.BaseUnitTest
+import to.bitkit.ui.Routes
 import to.bitkit.ui.components.Sheet
 import to.bitkit.ui.shared.toast.ToastQueueManager
 import to.bitkit.ui.sheets.SendRoute
@@ -93,6 +95,7 @@ class AppViewModelSendFlowTest : BaseUnitTest() {
     private val settingsData = MutableStateFlow(SettingsData())
     private val walletState = MutableStateFlow(WalletState())
     private val nodeEvents = MutableSharedFlow<Event>()
+    private val testPublicKey = "pubky3rsduhcxpw74snwyct86m38c63j3pq8x4ycqikxg64roik8yw5xg"
 
     private val timedSheetManager = mock<TimedSheetManager>()
 
@@ -123,6 +126,8 @@ class AppViewModelSendFlowTest : BaseUnitTest() {
         whenever { widgetsRepo.refreshEnabledWidgets() }.thenReturn(Unit)
         whenever { lightningRepo.updateGeoBlockState() }.thenReturn(Unit)
         whenever(pubkyRepo.sessionRestorationFailed).thenReturn(MutableStateFlow(false))
+        whenever(pubkyRepo.publicKey).thenReturn(MutableStateFlow(null))
+        whenever(pubkyRepo.contacts).thenReturn(MutableStateFlow(emptyList()))
         whenever(currencyRepo.convertSatsToFiat(any(), anyOrNull()))
             .thenReturn(Result.failure(Exception("not mocked")))
         whenever { lightningRepo.calculateTotalFee(any(), anyOrNull(), any(), anyOrNull(), anyOrNull()) }
@@ -218,6 +223,15 @@ class AppViewModelSendFlowTest : BaseUnitTest() {
         assertFalse(sut.sendUiState.value.canSwitchWallet)
     }
 
+    @Test
+    fun `manual address continue routes pubky to add contact`() = test {
+        sut.mainScreenEffect.test {
+            sut.setSendEvent(SendEvent.AddressContinue(testPublicKey))
+
+            assertEquals(MainScreenEffect.Navigate(Routes.AddContact(testPublicKey)), awaitItem())
+        }
+    }
+
     @Test
     fun `canSwitchWallet is false when amount exceeds lightning balance`() = test {
         balanceState.value = BalanceState(

changelog.d/next/931.fixed.md

@@ -0,0 +1 @@
+Improved public contact payment flows for manual Pubky entry, add-contact payments, and RBF activity display.