fix: propagate vss failure

Author: jvsena42

app/src/main/java/to/bitkit/repositories/LightningRepo.kt

@@ -483,13 +483,14 @@ class LightningRepo @Inject constructor(
             if (lightningService.node != null) {
                 lightningService.stop()
             }
-            clearNetworkGraph(walletIndex)
+            // Propagate VSS failures: a manual reset that leaves the graph in VSS is ineffective.
+            clearNetworkGraph(walletIndex).getOrThrow()
         }
     }
 
-    private suspend fun clearNetworkGraph(walletIndex: Int) {
+    private suspend fun clearNetworkGraph(walletIndex: Int): Result<Unit> {
         lightningService.resetNetworkGraph(walletIndex)
-        runCatching {
+        return runCatching {
             vssBackupClientLdk.setup(walletIndex).getOrThrow()
             vssBackupClientLdk.deleteObject("network_graph").getOrThrow()
             Logger.info("Cleared network graph from VSS", context = TAG)

app/src/test/java/to/bitkit/repositories/LightningRepoTest.kt

@@ -188,6 +188,18 @@ class LightningRepoTest : BaseUnitTest() {
         verify(vssBackupClientLdk).deleteObject(eq("network_graph"), any())
     }
 
+    @Test
+    fun `resetNetworkGraph fails when VSS delete fails`() = test {
+        whenever(vssBackupClientLdk.setup(any())).thenReturn(Result.success(Unit))
+        whenever(vssBackupClientLdk.deleteObject(any(), any()))
+            .thenReturn(Result.failure(RuntimeException("vss unavailable")))
+
+        val result = sut.resetNetworkGraph()
+
+        assertTrue(result.isFailure)
+        verify(lightningService).resetNetworkGraph(0)
+    }
+
     @Test
     fun `newAddress should fail when node is not running`() = test {
         val result = sut.newAddress()