chore: review

Author: ovitrif

app/src/androidTest/java/to/bitkit/ui/screens/wallets/send/SendAmountContentTest.kt

@@ -46,7 +46,7 @@ class SendAmountContentTest {
     fun whenNodeNotRunning_shouldShowSyncView() {
         composeTestRule.setContent {
             SendAmountContent(
-                nodeLifecycleState = nodeLifecycleState,
+                nodeLifecycleState = NodeLifecycleState.Initializing,
                 uiState = uiState,
                 amountInputViewModel = previewAmountInputViewModel(),
             )

app/src/main/java/to/bitkit/repositories/ActivityRepo.kt

@@ -346,7 +346,7 @@ class LightningRepo @Inject constructor(
                 lightningService.sync()
                 refreshChannelCache()
                 syncState()
-                if (syncPending.get()) delay(SYNC_LOOP_DEBOUNCE_MS)
+                if (syncPending.get()) delay(MS_SYNC_LOOP_DEBOUNCE)
             } while (syncPending.getAndSet(false))
         } finally {
             _lightningState.update { it.copy(isSyncingWallet = false) }
@@ -410,7 +410,7 @@ class LightningRepo @Inject constructor(
             }
 
             val channelName = channel.inboundScidAlias?.toString()
-                ?: (channel.channelId.take(CHANNEL_ID_PREVIEW_LENGTH) + "…")
+                ?: (channel.channelId.take(LENGTH_CHANNEL_ID_PREVIEW) + "…")
 
             val closedAt = (System.currentTimeMillis() / 1000L).toULong()
 
@@ -922,7 +922,9 @@ class LightningRepo @Inject constructor(
             return@runCatching replacementTxId
         }.onFailure {
             Logger.error(
-                "bumpFeeByRbf error originalTxId: $originalTxId, satsPerVByte: $satsPerVByte", it, context = TAG,
+                "bumpFeeByRbf error originalTxId: $originalTxId, satsPerVByte: $satsPerVByte",
+                it,
+                context = TAG,
             )
         }
     }
@@ -959,25 +961,25 @@ class LightningRepo @Inject constructor(
     }
 
     suspend fun estimateRoutingFees(bolt11: String): Result<ULong> = executeWhenNodeRunning("estimateRoutingFees") {
-        Logger.info("Estimating routing fees for bolt11: $bolt11")
+        Logger.info("Estimating routing fees for bolt11: $bolt11", context = TAG)
         lightningService.estimateRoutingFees(bolt11)
             .onSuccess {
                 Logger.info("Routing fees estimated: $it", context = TAG)
             }
             .onFailure {
-                Logger.error("Routing fees estimation failed", it, context = TAG)
+                Logger.error("estimateRoutingFees error", it, context = TAG)
             }
     }
 
     suspend fun estimateRoutingFeesForAmount(bolt11: String, amountSats: ULong): Result<ULong> =
         executeWhenNodeRunning("estimateRoutingFeesForAmount") {
-            Logger.info("Estimating routing fees for amount: $amountSats")
+            Logger.info("Estimating routing fees for amount: $amountSats", context = TAG)
             lightningService.estimateRoutingFeesForAmount(bolt11, amountSats)
                 .onSuccess {
                     Logger.info("Routing fees estimated: $it", context = TAG)
                 }
                 .onFailure {
-                    Logger.error("Routing fees estimation failed", it, context = TAG)
+                    Logger.error("estimateRoutingFees error", it, context = TAG)
                 }
         }
 
@@ -1006,8 +1008,8 @@ class LightningRepo @Inject constructor(
 
     companion object {
         private const val TAG = "LightningRepo"
-        private const val CHANNEL_ID_PREVIEW_LENGTH = 10
-        private const val SYNC_LOOP_DEBOUNCE_MS = 500L
+        private const val LENGTH_CHANNEL_ID_PREVIEW = 10
+        private const val MS_SYNC_LOOP_DEBOUNCE = 500L
     }
 }
 

app/src/main/java/to/bitkit/repositories/LightningRepo.kt

@@ -89,7 +89,7 @@ class ActivityListViewModel @Inject constructor(
         ) { debouncedSearch, filtersWithoutSearch, _ ->
             fetchFilteredActivities(filtersWithoutSearch.copy(searchText = debouncedSearch))
         }.collect {
-            _filteredActivities.value = it
+            _filteredActivities.update { it }
         }
     }
 
@@ -115,8 +115,8 @@ class ActivityListViewModel @Inject constructor(
             search = filters.searchText.takeIf { it.isNotEmpty() },
             minDate = filters.startDate?.let { it / 1000 }?.toULong(),
             maxDate = filters.endDate?.let { it / 1000 }?.toULong(),
-        ).getOrElse { e ->
-            Logger.error("Failed to filter activities", e)
+        ).getOrElse {
+            Logger.error("Failed to filter activities", it, context = TAG)
             return null
         }
 
@@ -132,9 +132,9 @@ class ActivityListViewModel @Inject constructor(
     private suspend fun filterOutReplacedSentTransactions(activities: List<Activity>): List<Activity> {
         val txIdsInBoostTxIds = activityRepo.getTxIdsInBoostTxIds()
 
-        return activities.filter { activity ->
-            if (activity is Activity.Onchain) {
-                val onchain = activity.v1
+        return activities.filter {
+            if (it is Activity.Onchain) {
+                val onchain = it.v1
                 if (!onchain.doesExist &&
                     onchain.txType == PaymentType.SENT &&
                     txIdsInBoostTxIds.contains(onchain.txId)
@@ -180,6 +180,7 @@ class ActivityListViewModel @Inject constructor(
     ): StateFlow<T> = stateIn(viewModelScope, started, initialValue)
 
     companion object {
+        private const val TAG = "ActivityListViewModel"
         private const val SIZE_LATEST = 3
         private const val MS_TIMEOUT_SUB = 5000L
     }