fix: disable retry for server changes

Author: jvsena42

app/src/main/java/to/bitkit/repositories/LightningRepo.kt

@@ -175,6 +175,7 @@ class LightningRepo @Inject constructor(
     suspend fun start(
         walletIndex: Int = 0,
         timeout: Duration? = null,
+        shouldRetry: Boolean = true,
         eventHandler: NodeEventHandler? = null,
         customServer: ElectrumServer? = null,
         customRgsServerUrl: String? = null,
@@ -199,7 +200,7 @@ class LightningRepo @Inject constructor(
                     }
 
                     // Handle setup failures with retry logic
-                    if (retryAttempt < MAX_RETRY_ATTEMPTS && isRetryableError(setupError)) {
+                    if (shouldRetry && retryAttempt < MAX_RETRY_ATTEMPTS && isRetryableError(setupError)) {
                         Logger.warn(
                             "Setup failed (attempt ${retryAttempt + 1}/$MAX_RETRY_ATTEMPTS), retrying...",
                             setupError,
@@ -212,6 +213,7 @@ class LightningRepo @Inject constructor(
                         return@withContext start(
                             walletIndex = walletIndex,
                             timeout = timeout,
+                            shouldRetry = shouldRetry,
                             eventHandler = eventHandler,
                             customServer = customServer,
                             customRgsServerUrl = customRgsServerUrl,
@@ -263,7 +265,7 @@ class LightningRepo @Inject constructor(
                 it.copy(nodeLifecycleState = NodeLifecycleState.ErrorStarting(e))
             }
 
-            if (retryAttempt < MAX_RETRY_ATTEMPTS && isRetryableError(e)) {
+            if (shouldRetry && retryAttempt < MAX_RETRY_ATTEMPTS && isRetryableError(e)) {
                 Logger.warn(
                     "Start failed (attempt ${retryAttempt + 1}/$MAX_RETRY_ATTEMPTS), retrying...",
                     e,
@@ -427,6 +429,7 @@ class LightningRepo @Inject constructor(
         start(
             eventHandler = cachedEventHandler,
             customServer = newServer,
+            shouldRetry = false, // Disable retry for server changes
         ).onFailure { startError ->
             Logger.warn("Failed ldk-node config change, attempting recovery…")
             restartWithPreviousConfig()
@@ -452,6 +455,7 @@ class LightningRepo @Inject constructor(
 
         start(
             eventHandler = cachedEventHandler,
+            shouldRetry = false, // Disable retry for server changes
             customRgsServerUrl = newRgsUrl,
         ).onFailure { startError ->
             Logger.warn("Failed ldk-node config change, attempting recovery…")