refactor: use class for all errors to fix warnings

Author: ovitrif

app/src/main/java/to/bitkit/data/ChatwootHttpClient.kt

@@ -60,5 +60,5 @@ class ChatwootHttpClient @Inject constructor(
 }
 
 sealed class ChatwootHttpError(message: String) : AppError(message) {
-    data class InvalidResponse(override val message: String) : ChatwootHttpError(message)
+    class InvalidResponse(override val message: String) : ChatwootHttpError(message)
 }

app/src/main/java/to/bitkit/data/backup/VssBackupClient.kt

@@ -40,7 +40,7 @@ class VssBackupClient @Inject constructor(
                 Logger.verbose("Building VSS client with lnurlAuthServerUrl: '$lnurlAuthServerUrl'")
                 if (lnurlAuthServerUrl.isNotEmpty()) {
                     val mnemonic = keychain.loadString(Keychain.Key.BIP39_MNEMONIC.name)
-                        ?: throw ServiceError.MnemonicNotFound
+                        ?: throw ServiceError.MnemonicNotFound()
                     val passphrase = keychain.loadString(Keychain.Key.BIP39_PASSPHRASE.name)
 
                     vssNewClientWithLnurlAuth(

app/src/main/java/to/bitkit/data/backup/VssStoreIdProvider.kt

@@ -19,7 +19,8 @@ class VssStoreIdProvider @Inject constructor(
         synchronized(this) {
             cacheMap[walletIndex]?.let { return it }
 
-            val mnemonic = keychain.loadString(Keychain.Key.BIP39_MNEMONIC.name) ?: throw ServiceError.MnemonicNotFound
+            val mnemonic = keychain.loadString(Keychain.Key.BIP39_MNEMONIC.name)
+                ?: throw ServiceError.MnemonicNotFound()
             val passphrase = keychain.loadString(Keychain.Key.BIP39_PASSPHRASE.name)
 
             val storeId = vssDeriveStoreId(

app/src/main/java/to/bitkit/data/widgets/BlocksService.kt

@@ -101,5 +101,5 @@ class BlocksService @Inject constructor(
  * Block-specific error types
  */
 sealed class BlockError(message: String) : AppError(message) {
-    data class InvalidResponse(override val message: String) : BlockError(message)
+    class InvalidResponse(override val message: String) : BlockError(message)
 }

app/src/main/java/to/bitkit/data/widgets/NewsService.kt

@@ -52,5 +52,5 @@ class NewsService @Inject constructor(
  * News-specific error types
  */
 sealed class NewsError(message: String) : AppError(message) {
-    data class InvalidResponse(override val message: String) : NewsError(message)
+    class InvalidResponse(override val message: String) : NewsError(message)
 }

app/src/main/java/to/bitkit/data/widgets/PriceService.kt

@@ -180,6 +180,6 @@ class PriceService @Inject constructor(
  * Price-specific error types
  */
 sealed class PriceError(message: String) : AppError(message) {
-    data class InvalidResponse(override val message: String) : PriceError(message)
-    data class NetworkError(override val message: String) : PriceError(message)
+    class InvalidResponse(override val message: String) : PriceError(message)
+    class NetworkError(override val message: String) : PriceError(message)
 }

app/src/main/java/to/bitkit/repositories/BlocktankRepo.kt

@@ -201,8 +201,8 @@ class BlocktankRepo @Inject constructor(
         description: String = Env.DEFAULT_INVOICE_MESSAGE,
     ): Result<IcJitEntry> = withContext(bgDispatcher) {
         try {
-            if (coreService.isGeoBlocked()) throw ServiceError.GeoBlocked
-            val nodeId = lightningService.nodeId ?: throw ServiceError.NodeNotStarted
+            if (coreService.isGeoBlocked()) throw ServiceError.GeoBlocked()
+            val nodeId = lightningService.nodeId ?: throw ServiceError.NodeNotStarted()
             val lspBalance = getDefaultLspBalance(clientBalance = amountSats)
             val channelSizeSat = amountSats + lspBalance
 
@@ -230,7 +230,7 @@ class BlocktankRepo @Inject constructor(
         channelExpiryWeeks: UInt = DEFAULT_CHANNEL_EXPIRY_WEEKS,
     ): Result<IBtOrder> = withContext(bgDispatcher) {
         try {
-            if (coreService.isGeoBlocked()) throw ServiceError.GeoBlocked
+            if (coreService.isGeoBlocked()) throw ServiceError.GeoBlocked()
 
             val options = defaultCreateOrderOptions(clientBalanceSat = spendingBalanceSats)
 
@@ -323,7 +323,7 @@ class BlocktankRepo @Inject constructor(
     }
 
     private suspend fun defaultCreateOrderOptions(clientBalanceSat: ULong): CreateOrderOptions {
-        val nodeId = lightningService.nodeId ?: throw ServiceError.NodeNotStarted
+        val nodeId = lightningService.nodeId ?: throw ServiceError.NodeNotStarted()
         val timestamp = nowTimestamp().toString()
         val signature = lightningService.sign("channelOpen-$timestamp")
 
@@ -350,7 +350,7 @@ class BlocktankRepo @Inject constructor(
         }
 
         val satsPerEur = getSatsPerEur()
-            ?: throw ServiceError.CurrencyRateUnavailable
+            ?: throw ServiceError.CurrencyRateUnavailable()
 
         val params = DefaultLspBalanceParams(
             clientBalanceSat = clientBalance,
@@ -363,10 +363,10 @@ class BlocktankRepo @Inject constructor(
 
     fun calculateLiquidityOptions(clientBalanceSat: ULong): Result<ChannelLiquidityOptions> {
         val blocktankInfo = blocktankState.value.info
-            ?: return Result.failure(ServiceError.BlocktankInfoUnavailable)
+            ?: return Result.failure(ServiceError.BlocktankInfoUnavailable())
 
         val satsPerEur = getSatsPerEur()
-            ?: return Result.failure(ServiceError.CurrencyRateUnavailable)
+            ?: return Result.failure(ServiceError.CurrencyRateUnavailable())
 
         val existingChannelsTotalSat = totalBtChannelsValueSats(blocktankInfo)
 
@@ -466,7 +466,7 @@ class BlocktankRepo @Inject constructor(
     }
 
     private suspend fun claimGiftCodeWithoutLiquidity(code: String, amount: ULong): GiftClaimResult {
-        val nodeId = lightningService.nodeId ?: throw ServiceError.NodeNotStarted
+        val nodeId = lightningService.nodeId ?: throw ServiceError.NodeNotStarted()
 
         val order = ServiceQueue.CORE.background {
             giftOrder(clientNodeId = nodeId, code = "blocktank-gift-code:$code")

app/src/main/java/to/bitkit/repositories/LightningRepo.kt

@@ -628,7 +628,7 @@ class LightningRepo @Inject constructor(
         callback: String,
         domain: String,
     ): Result<String> = runCatching {
-        val mnemonic = keychain.loadString(Keychain.Key.BIP39_MNEMONIC.name) ?: throw ServiceError.MnemonicNotFound
+        val mnemonic = keychain.loadString(Keychain.Key.BIP39_MNEMONIC.name) ?: throw ServiceError.MnemonicNotFound()
         val passphrase = keychain.loadString(Keychain.Key.BIP39_PASSPHRASE.name)
 
         val result = lnurlAuth(

app/src/main/java/to/bitkit/repositories/WalletRepo.kt

@@ -347,7 +347,8 @@ class WalletRepo @Inject constructor(
         count: Int = 20,
     ): Result<List<AddressModel>> = withContext(bgDispatcher) {
         return@withContext try {
-            val mnemonic = keychain.loadString(Keychain.Key.BIP39_MNEMONIC.name) ?: throw ServiceError.MnemonicNotFound
+            val mnemonic = keychain.loadString(Keychain.Key.BIP39_MNEMONIC.name)
+                ?: throw ServiceError.MnemonicNotFound()
 
             val passphrase = keychain.loadString(Keychain.Key.BIP39_PASSPHRASE.name)
 

app/src/main/java/to/bitkit/services/AppUpdaterService.kt

@@ -37,5 +37,5 @@ class AppUpdaterService @Inject constructor(
 }
 
 sealed class AppUpdaterError(message: String) : AppError(message) {
-    data class InvalidResponse(override val message: String) : AppUpdaterError(message)
+    class InvalidResponse(override val message: String) : AppUpdaterError(message)
 }