You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
if possible consider ordering suggestion of OS widgets on add screen (IMHO price, blocks, weather could be on top if possible)
NOT POSSIBLE
in app small widget support... either support it in app view or remove small preview for now. Otherwise it may be a bit confusing as why only wide version is supported despite saving the small one.
Open app when tapping widgets without settings (Calculator, Facts)
Add support for Android OS Widget Settings menu and drag&drop area
Menu
Drag&Drop Area
Replace first preview in WidgetSizeCarousel to show the wide view by default
also refactor to support passing startingSlide from outside (as fn arg) and update each widget composable previews to include a preview screen for each slide and make sure all widget composable previews are annotated with @Preview(showSystemUi = true) instead of passing showBackground=true.
Found a couple of UI nits worth polishing in another PR:
Part 1
1. Bg Color Issue
Screen in
AppWidgetConfigActivitydoesn't have same BG color as the bitkit app, apparently.While that's not the main issue, it leads to these visible differences in bg between system bars and app bg:
Most likely the fix is to enable edge to edge like we do in
MainActivity.kt#L892. New Select Option UI Control Jump
There's a slightly visible jump on UI when changing widget options using the new select component, visible on tap:
uiglitch.mp4
Originally posted by @ovitrif in #895 (review)
Part 2
I've approved all individual stacked PRs. I think it looks good functionally. Also e2e tests updated to cover in app redesigned widgets.
There are some outstanding items that I think would be good to address before releasing this feature:
if possible consider ordering suggestion of OS widgets on add screen (IMHO price, blocks, weather could be on top if possible)NOT POSSIBLEOriginally posted by @piotr-iohk in #895 (comment)
Part 3
WidgetSizeCarouselto show the wide view by defaultstartingSlidefrom outside (as fn arg) and update each widget composable previews to include a preview screen for each slide and make sure all widget composable previews are annotated with@Preview(showSystemUi = true)instead of passingshowBackground=true.