Skip to content

fix: tune lightning probe routing#1052

Merged
pwltr merged 4 commits into
masterfrom
feat/scorer-params
Jul 14, 2026
Merged

fix: tune lightning probe routing#1052
pwltr merged 4 commits into
masterfrom
feat/scorer-params

Conversation

@pwltr

@pwltr pwltr commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Description

Improves Lightning route selection and diagnostics.

  • Bumps ldk-node-android to 0.7.0-rc.52
  • Uses routeFeeMsat from LDK probe events for successful and failed probes
  • Shows the returned route fee in the probing tool instead of estimating it afterward
  • Preserves large shortChannelId values as strings to avoid JS precision loss in E2E reports
  • Tunes node-wide scorer fee params from the ldk-node defaults with selected overrides

iOS counterparts: synonymdev/bitkit-ios#622 synonymdev/bitkit-ios#623

Preview

N/A

QA Notes

  • Added/updated coverage in LightningRepoTest.kt
  • Added/updated coverage in ProbingToolViewModelTest.kt
  • Ran git diff --cached --check
  • :app:compileMainnetDebugKotlin was attempted during the branch work, but Gradle stalled at the Kotlin compile task with no compiler error output

Comment thread app/src/test/java/to/bitkit/viewmodels/ProbingToolViewModelTest.kt Fixed
Comment thread app/src/test/java/to/bitkit/viewmodels/ProbingToolViewModelTest.kt Fixed
Comment thread app/src/test/java/to/bitkit/viewmodels/ProbingToolViewModelTest.kt Fixed
Comment thread app/src/test/java/to/bitkit/viewmodels/ProbingToolViewModelTest.kt Fixed
Comment thread app/src/test/java/to/bitkit/viewmodels/ProbingToolViewModelTest.kt Fixed
Comment thread app/src/test/java/to/bitkit/viewmodels/ProbingToolViewModelTest.kt Fixed
Comment thread app/src/test/java/to/bitkit/viewmodels/ProbingToolViewModelTest.kt Fixed
Comment thread app/src/test/java/to/bitkit/viewmodels/ProbingToolViewModelTest.kt Fixed
Comment thread app/src/test/java/to/bitkit/viewmodels/ProbingToolViewModelTest.kt Fixed
Comment thread app/src/test/java/to/bitkit/viewmodels/ProbingToolViewModelTest.kt Fixed
@piotr-iohk

Copy link
Copy Markdown
Collaborator

@pwltr the nightly probing results against this branch have been quite good. Is this PR ready to be undrafted? I suppose we also need one for bitkit-ios?

@pwltr pwltr force-pushed the feat/scorer-params branch from 75dd73c to 5b6d7b2 Compare July 14, 2026 10:04
@pwltr pwltr marked this pull request as ready for review July 14, 2026 10:09
@greptile-apps

greptile-apps Bot commented Jul 14, 2026

Copy link
Copy Markdown

Greptile Summary

This PR updates Lightning probe routing and fee reporting. The main changes are:

  • Bumps ldk-node-android to 0.7.0-rc.52.
  • Passes LDK routeFeeMsat through probe outcomes and the probing UI.
  • Converts failed probe shortChannelId values to strings.
  • Adds node-wide scoring fee parameter overrides.
  • Updates probe-related tests and changelog notes.

Confidence Score: 4/5

The probe failure channel ID schema needs to be fixed before merging.

  • The repository layer now exposes failed probe channel IDs as strings.
  • At least one existing reporting path still expects the old numeric shape.
  • The route fee UI flow and updated tests otherwise follow the changed probe outcome data.

app/src/main/java/to/bitkit/repositories/LightningRepo.kt and probe report consumers

Important Files Changed

Filename Overview
app/src/main/java/to/bitkit/repositories/LightningRepo.kt Adds route fee fields and changes failed probe channel IDs to strings, but the type change is not propagated to all consumers.
app/src/main/java/to/bitkit/viewmodels/ProbingToolViewModel.kt Displays the LDK-provided probe route fee instead of a post-probe estimate.
app/src/main/java/to/bitkit/ui/screens/settings/ProbingToolScreen.kt Renames the displayed fee row and shows route fees in msat.
app/src/main/java/to/bitkit/services/LightningService.kt Applies custom scoring fee parameters during Lightning node setup.
gradle/libs.versions.toml Updates the Android LDK node dependency version.

Reviews (1): Last reviewed commit: "fix: tune scorer fee params" | Re-trigger Greptile

Comment thread app/src/main/java/to/bitkit/repositories/LightningRepo.kt

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5b6d7b2691

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread app/src/main/java/to/bitkit/repositories/LightningRepo.kt
Comment thread app/src/main/java/to/bitkit/services/LightningService.kt Fixed
Comment thread app/src/main/java/to/bitkit/services/LightningService.kt Fixed
@pwltr

pwltr commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

Comment thread app/src/main/java/to/bitkit/services/LightningService.kt Dismissed
@pwltr pwltr requested review from jvsena42 and piotr-iohk July 14, 2026 11:16
Comment thread gradle/libs.versions.toml
@pwltr pwltr merged commit bfc6958 into master Jul 14, 2026
18 checks passed
@pwltr pwltr deleted the feat/scorer-params branch July 14, 2026 13:44
This was referenced Jul 14, 2026
pwltr added a commit that referenced this pull request Jul 14, 2026
* feat: show probe route fee

* fix: tune scorer fee params

* fix: address probe compile errors

* fix: use scorer defaults
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants