fix: tune lightning probe routing#1052
Conversation
948c097 to
965b4d4
Compare
|
@pwltr the nightly probing results against this branch have been quite good. Is this PR ready to be undrafted? I suppose we also need one for bitkit-ios? |
75dd73c to
5b6d7b2
Compare
Greptile SummaryThis PR updates Lightning probe routing and fee reporting. The main changes are:
Confidence Score: 4/5The probe failure channel ID schema needs to be fixed before merging.
app/src/main/java/to/bitkit/repositories/LightningRepo.kt and probe report consumers
|
| Filename | Overview |
|---|---|
| app/src/main/java/to/bitkit/repositories/LightningRepo.kt | Adds route fee fields and changes failed probe channel IDs to strings, but the type change is not propagated to all consumers. |
| app/src/main/java/to/bitkit/viewmodels/ProbingToolViewModel.kt | Displays the LDK-provided probe route fee instead of a post-probe estimate. |
| app/src/main/java/to/bitkit/ui/screens/settings/ProbingToolScreen.kt | Renames the displayed fee row and shows route fees in msat. |
| app/src/main/java/to/bitkit/services/LightningService.kt | Applies custom scoring fee parameters during Lightning node setup. |
| gradle/libs.versions.toml | Updates the Android LDK node dependency version. |
Reviews (1): Last reviewed commit: "fix: tune scorer fee params" | Re-trigger Greptile
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5b6d7b2691
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
* feat: show probe route fee * fix: tune scorer fee params * fix: address probe compile errors * fix: use scorer defaults
Description
Improves Lightning route selection and diagnostics.
ldk-node-androidto0.7.0-rc.52routeFeeMsatfrom LDK probe events for successful and failed probesshortChannelIdvalues as strings to avoid JS precision loss in E2E reportsiOS counterparts: synonymdev/bitkit-ios#622 synonymdev/bitkit-ios#623
Preview
N/A
QA Notes
LightningRepoTest.ktProbingToolViewModelTest.ktgit diff --cached --check:app:compileMainnetDebugKotlinwas attempted during the branch work, but Gradle stalled at the Kotlin compile task with no compiler error output