refactor: remove dependency on LDK#596
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
4 tasks
123d173 to
eb48e90
Compare
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Member
|
LGTM, I'll test it when the conflicts are solved |
ben-kaufman
reviewed
Jan 12, 2026
# Conflicts: # .claude/commands/pr.md # app/src/main/java/to/bitkit/services/RNBackupClient.kt # gradle/libs.versions.toml
Collaborator
Author
|
Need a new fix in |
Collaborator
Author
|
PR now ready & tested on Regtest and Mainnet. |
Contributor
|
Looks like ldk node is still at rc.4 should update to use rc.6 |
Collaborator
Author
Indeed, pushed only now 👍🏻 thx for reminder in slack 🙏🏻 |
ben-kaufman
approved these changes
Jan 13, 2026
ben-kaufman
left a comment
Contributor
There was a problem hiding this comment.
tAck, recovery works as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrates:
derive_node_secret_from_mnemonicto match KeysManager ldk-node#28This PR removes the dependency on LDK from the migration code by using the new
deriveNodeSecretFromMnemonicfunction exposed by ldk-node instead.Description
deriveNodeSecretFromMnemonicfunction from ldk-nodeget_node_secret_keywhich was fragiletoHeximplementations by using the shared extension functionv0.7.0-rc.3Preview
N/a
QA Notes
Tests:
1. Migration from RN
build.gradle.kts:65clear the string forapplicationIdSuffixIt should be:
applicationIdSuffix = ""