fix: migrate activities for unsupported addresses#605
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
5c68064 to
1da9cae
Compare
This comment has been minimized.
This comment has been minimized.
6565eba to
ee7c812
Compare
Contributor
Code reviewFound 1 issue related to CLAUDE.md compliance: PR Description FormatThe PR description does not follow the required template structure defined in CLAUDE.md rule (line 206): "ALWAYS use template in Current description structure:
Required template structure:
Please update the PR description to use the template headers. Code changes: No bugs or CLAUDE.md violations found in the code itself. The migration logic and value preservation approach look good. |
Member
|
utAck, testing... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes missing activities when migrating RN app which had activities of unsupported address types.
Testing:
Could use this seed which has example recceving to each address type this making 2 send txs:
Note
The RN app doesn't back up on-chain activities on the remote backup, which means if user recovers using mnemonic and RN backup activities from unsupported address types won't show up.