fix: sync exception causing infinite loop on start#657
Conversation
This comment has been minimized.
This comment has been minimized.
This comment was marked as resolved.
This comment was marked as resolved.
This comment has been minimized.
This comment has been minimized.
This comment was marked as resolved.
This comment was marked as resolved.
|
I managed to crash Bitkit on this branch, could be not related with the changes, nor the original issue though.
Accoriging to AI: AI proposed fix: Summary of Changes1. VssBackupClient.kt
2. BackupRepo.kt
Behavior
|
Thanks! It is a different issue #553 . It was closed because we couldn't reproduce it again |
Fixes #652
Fixes #676
Fixes #662
This PR fixes the "Bitkit keeps stopping" crash that occurs after wallet restoration when LDK's transaction sync encounters an unconfirmed channel funding transaction on Electrum.
Description
The root cause was that after wallet restoration, LDK couldn't find a confirmed channel's funding transaction on Electrum, because it is a zero-conf channel restored before the transaction is confirmed, causing an infinite retry loop until timeout.
Also the retry flow was setting the node state as initialLifecycleState on repository, even it being running on service
Preview
master-with-crash.webm
fixed.webm
Uploading migration.webm…
QA Notes
1. Verify sync error handling
2. Migration