fix: improve foreground notification#687
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This comment was marked as resolved.
This comment was marked as resolved.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Still not tested the adb commands |
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #651
Fixes #658
This PR fixes multiple issues with the foreground notification in
LightningNodeService:Description
.setOngoing(true)onTimeout()callbackstartForeground()callPreview
api-level-36.webm
api-level-33.webm
QA Notes
1. Non-dismissable notification
2. Notification appearance
3. Android 15+ timeout handling (optional)
To test the FGS timeout on Android 15 (not above):
adb shell am compat enable FGS_INTRODUCE_TIME_LIMITS to.bitkit adb shell device_config put activity_manager data_sync_fgs_timeout_duration 60000Wait 60 seconds and verify the service stops gracefully without crash.