ci: trigger on ready_for_review event#705
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
ci: add path filter to e2e workflow
piotr-iohk
previously approved these changes
Jan 22, 2026
jvsena42
previously approved these changes
Jan 22, 2026
Collaborator
|
Added 6d2234b to also trigger on workflow change. |
piotr-iohk
approved these changes
Jan 22, 2026
Collaborator
Author
|
need re-approve. Piotr's approval should work now given latest commit by GitHub in my own name |
jvsena42
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes CI not running when a draft PR is marked "ready for review".
Description
The
pull_requesttrigger defaults to[opened, synchronize, reopened]types, which doesn't includeready_for_review. When a draft PR is undrafted, no CI runs because:if: github.event.pull_request.draft == falseready_for_reviewevent isn't in the trigger listThis adds
ready_for_reviewto the trigger types so CI runs when PRs are marked ready for review.Preview
N/A - workflow change
QA Notes