Skip to content

Commit 1d0149b

Browse files
authored
Merge pull request #190 from synonymdev/fix/probe-step-summary-append
fix: avoid repeated probe summaries
2 parents 67156e9 + 83f83ee commit 1d0149b

2 files changed

Lines changed: 4 additions & 3 deletions

File tree

test/helpers/probe.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -518,7 +518,8 @@ export async function waitForProbeReadiness({
518518

519519
export function writeProbeArtifacts(
520520
results: ProbeResult[],
521-
readiness?: ProbeReadiness | null
521+
readiness?: ProbeReadiness | null,
522+
options: { writeStepSummary?: boolean } = {}
522523
): void {
523524
const artifactsDir = resolveArtifactsDir();
524525
fs.mkdirSync(artifactsDir, { recursive: true });
@@ -535,7 +536,7 @@ export function writeProbeArtifacts(
535536
fs.writeFileSync(readinessPath, `${JSON.stringify(readiness, null, 2)}\n`);
536537
}
537538

538-
if (process.env.GITHUB_STEP_SUMMARY) {
539+
if (options.writeStepSummary !== false && process.env.GITHUB_STEP_SUMMARY) {
539540
fs.appendFileSync(
540541
process.env.GITHUB_STEP_SUMMARY,
541542
`\n## Attempt ${resolveAttempt()}\n\n${report}\n`

test/specs/mainnet/probe.e2e.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ describe('@probe_mainnet - Lightning probe smoke', () => {
247247
for (const [index, { target, amountMsat }] of probes.entries()) {
248248
const result = await runProbe(target, amountMsat);
249249
results.push(result);
250-
writeProbeArtifacts(results, readiness);
250+
writeProbeArtifacts(results, readiness, { writeStepSummary: false });
251251
console.info(
252252
`→ [Probe] ${result.targetName} ${result.amountSats} sats (${result.probeMode}): ${
253253
result.success ? '✅ success' : `❌ failed (${result.error ?? 'unknown'})`

0 commit comments

Comments
 (0)