fix: avoid repeated probe summaries#190
Open
piotr-iohk wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
This regression was introduced by #188, which intentionally started writing probe artifacts after each individual probe result so long-running mainnet probe runs keep partial diagnostics if they fail mid-run.
That change worked for artifact files because
probe-results.jsonandprobe-report.mdare overwritten on every write. However,writeProbeArtifacts()also appends toGITHUB_STEP_SUMMARY, so every partial write appended the whole growing report again.The result is visible in this run summary:
https://github.com/synonymdev/bitkit-nightly/actions/runs/28343008353/jobs/67064661419/summary_raw
The uploaded diagnostics artifact still contains a correct final
probe-report.md; only the GitHub job summary is repeated/expanded after each probe.Fix
This keeps the useful #188 behavior for partial artifact files, but disables step-summary writes for those partial updates. The final
finallyblock still writes the GitHub step summary once, after the run has the final result set.Test plan
npx eslint test/helpers/probe.ts test/specs/mainnet/probe.e2e.ts