Skip to content

Commit 8f8f7ec

Browse files
committed
refactor: trim inline comments in AppScene per review
Remove the self-explanatory comment on the root app-update sheet and the onReceive note (reevaluate()'s doc already covers the late-arrival why). Keep a short note only for the non-obvious "app-update is the sole wallet-independent timed sheet" invariant at the onboarding trigger.
1 parent 2d5a2ad commit 8f8f7ec

1 file changed

Lines changed: 2 additions & 8 deletions

File tree

Bitkit/AppScene.swift

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -100,8 +100,6 @@ struct AppScene: View {
100100
) {
101101
config in ForgotPinSheet(config: config)
102102
}
103-
// Presented at the root (not in MainNavView) so the non-critical update prompt
104-
// can also surface during onboarding, before a wallet exists (issue #460).
105103
.sheet(
106104
item: $sheets.appUpdateSheetItem,
107105
onDismiss: {
@@ -214,9 +212,6 @@ struct AppScene: View {
214212
handleBackupFailure(intervalMinutes: intervalMinutes)
215213
}
216214
.onReceive(AppUpdateService.shared.$availableUpdate) { update in
217-
// The update check finishes asynchronously. If it lands after the initial settle
218-
// check (common on a fresh first launch), re-run the evaluation so the non-critical
219-
// prompt still surfaces instead of waiting for the next primary-screen entry (issue #460).
220215
guard update != nil else { return }
221216
TimedSheetManager.shared.reevaluate()
222217
}
@@ -353,9 +348,8 @@ struct AppScene: View {
353348
walletIsInitializing = nil
354349
walletInitShouldFinish = false
355350

356-
// Let the non-critical update prompt reach the onboarding flow too (issue #460).
357-
// Only the app-update sheet can pass shouldShow() without a wallet, so this won't
358-
// surface wallet-related timed sheets here.
351+
// Only the app-update sheet qualifies without a wallet, so onboarding
352+
// won't surface the other (wallet-gated) timed sheets.
359353
TimedSheetManager.shared.onPrimaryScreenEntered()
360354
}
361355
.onDisappear {

0 commit comments

Comments
 (0)