Skip to content

Commit fd1d1f8

Browse files
ovitrifclaude
andcommitted
fix: restore LDK Node rev to v0.7.0-rc.36 and add LightningAmountConversion to notification target
The previous commit (851826f) reverted the LDK Node pin to c5698d0, thinking it was the master-pinned version. But master had already moved to ae38ead (v0.7.0-rc.36) via PR #502 (stale monitor recovery), which added BuildError.DangerousValue. This caused three build errors: - "Type 'BuildError' has no member 'DangerousValue'" (Bitkit, BitkitNotification, BitkitTests) - "Cannot find 'LightningAmountConversion' in scope" (BitkitNotification) The revision was hardcoded in the pbxproj package requirement (not just Package.resolved), so Xcode kept re-resolving to the old version on every build. Additionally, the project had two conflicting ldk-node package references: lightningdevkit/ldk-node (tracking main branch) and synonymdev/ldk-node (pinned revision). Both shared the same SPM identity, causing resolution failures after SPM cache resets. Fixes: - Update ldk-node revision in pbxproj to ae38ead (v0.7.0-rc.36) - Add LightningAmountConversion.swift to BitkitNotification target (PaymentDetails.swift was already in that target but referenced it) - Remove stale lightningdevkit/ldk-node package reference and rewire Bitkit target to use synonymdev/ldk-node (single source of truth) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 36af4da commit fd1d1f8

2 files changed

Lines changed: 4 additions & 11 deletions

File tree

Bitkit.xcodeproj/project.pbxproj

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,7 @@
123123
Utilities/Crypto.swift,
124124
Utilities/Errors.swift,
125125
Utilities/Keychain.swift,
126+
Utilities/LightningAmountConversion.swift,
126127
Utilities/Logger.swift,
127128
Utilities/StateLocker.swift,
128129
);
@@ -917,20 +918,12 @@
917918
minimumVersion = 2.1.2;
918919
};
919920
};
920-
962045C92DE998F1007BAA26 /* XCRemoteSwiftPackageReference "ldk-node" */ = {
921-
isa = XCRemoteSwiftPackageReference;
922-
repositoryURL = "https://github.com/lightningdevkit/ldk-node";
923-
requirement = {
924-
branch = main;
925-
kind = branch;
926-
};
927-
};
928921
968FE13E2DFB016B0053CD7F /* XCRemoteSwiftPackageReference "ldk-node" */ = {
929922
isa = XCRemoteSwiftPackageReference;
930923
repositoryURL = "https://github.com/synonymdev/ldk-node";
931924
requirement = {
932925
kind = revision;
933-
revision = c5698d00066e0e50f33696afc562d71023da2373;
926+
revision = ae38eadab70fceb5dbe242bc02bf895581cb7c3f;
934927
};
935928
};
936929
96DEA0382DE8BBA1009932BF /* XCRemoteSwiftPackageReference "bitkit-core" */ = {
@@ -987,7 +980,7 @@
987980
};
988981
9613018B2C5022D700878183 /* LDKNode */ = {
989982
isa = XCSwiftPackageProductDependency;
990-
package = 962045C92DE998F1007BAA26 /* XCRemoteSwiftPackageReference "ldk-node" */;
983+
package = 968FE13E2DFB016B0053CD7F /* XCRemoteSwiftPackageReference "ldk-node" */;
991984
productName = LDKNode;
992985
};
993986
968FE13F2DFB016B0053CD7F /* LDKNode */ = {

Bitkit.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)