Commit fd1d1f8
fix: restore LDK Node rev to v0.7.0-rc.36 and add LightningAmountConversion to notification target
The previous commit (851826f) reverted the LDK Node pin to c5698d0,
thinking it was the master-pinned version. But master had already moved
to ae38ead (v0.7.0-rc.36) via PR #502 (stale monitor recovery), which
added BuildError.DangerousValue.
This caused three build errors:
- "Type 'BuildError' has no member 'DangerousValue'" (Bitkit, BitkitNotification, BitkitTests)
- "Cannot find 'LightningAmountConversion' in scope" (BitkitNotification)
The revision was hardcoded in the pbxproj package requirement (not just
Package.resolved), so Xcode kept re-resolving to the old version on
every build.
Additionally, the project had two conflicting ldk-node package
references: lightningdevkit/ldk-node (tracking main branch) and
synonymdev/ldk-node (pinned revision). Both shared the same SPM
identity, causing resolution failures after SPM cache resets.
Fixes:
- Update ldk-node revision in pbxproj to ae38ead (v0.7.0-rc.36)
- Add LightningAmountConversion.swift to BitkitNotification target
(PaymentDetails.swift was already in that target but referenced it)
- Remove stale lightningdevkit/ldk-node package reference and rewire
Bitkit target to use synonymdev/ldk-node (single source of truth)
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>1 parent 36af4da commit fd1d1f8
2 files changed
Lines changed: 4 additions & 11 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
123 | 123 | | |
124 | 124 | | |
125 | 125 | | |
| 126 | + | |
126 | 127 | | |
127 | 128 | | |
128 | 129 | | |
| |||
917 | 918 | | |
918 | 919 | | |
919 | 920 | | |
920 | | - | |
921 | | - | |
922 | | - | |
923 | | - | |
924 | | - | |
925 | | - | |
926 | | - | |
927 | | - | |
928 | 921 | | |
929 | 922 | | |
930 | 923 | | |
931 | 924 | | |
932 | 925 | | |
933 | | - | |
| 926 | + | |
934 | 927 | | |
935 | 928 | | |
936 | 929 | | |
| |||
987 | 980 | | |
988 | 981 | | |
989 | 982 | | |
990 | | - | |
| 983 | + | |
991 | 984 | | |
992 | 985 | | |
993 | 986 | | |
| |||
Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments