fix: tune lightning probe routing

[pwltr]

Description

Tunes Lightning scorer fee parameters to improve route selection reliability.

• Applies custom scorer fee parameters during LDK node setup.
• Keeps unspecified scorer fields from the default LDK config.
• Stores probe failure shortChannelId as a string for diagnostic display.

Android counterpart: synonymdev/bitkit-android#1052

[greptile-apps]

Greptile Summary

This PR tunes Lightning probe routing behavior. The main changes are:

• Custom scorer fee parameters during Lightning node setup.
• Default scorer fields preserved for unspecified values.
• Probe failure short channel IDs stored as strings for display.
• A changelog entry for route selection reliability.

Confidence Score: 4/5

Lightning setup can crash when the default scorer parameters are absent.

• The new setup call always builds scorer parameters.
• That builder path force-unwraps config.scoringFeeParams.
• The probe short channel ID string change is localized to diagnostic display.

Bitkit/Services/LightningService.swift

Important Files Changed

Filename	Overview
Bitkit/Services/LightningService.swift	Adds scorer fee tuning during node setup, with a crash risk from force-unwrapping optional default scorer parameters.
Bitkit/ViewModels/WalletViewModel.swift	Changes probe failure short channel ID handling from numeric storage to string storage for diagnostic output.
Bitkit/Views/Settings/ProbingTool/ProbingToolScreen.swift	Displays the string short channel ID directly in the probe failure message.
changelog.d/next/623.fixed.md	Adds a fixed changelog note for improved Lightning route selection reliability.

_{Reviews (1): Last reviewed commit: "fix: tune lightning probe routing" | Re-trigger Greptile}

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7788d3e637

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[piotr-iohk]

utACK