[Type]: parent type is missing

[NullVoxPopuli]

Initial checklist

• I read the support docs
• I read the contributing guide
• I agree to follow the code of conduct
• I searched issues and discussions and couldn’t find anything (or linked relevant results below)

Affected package

unist-util-visit

Steps to reproduce

use typescript, have a simple plugin:

import type { Pluggable } from 'unified'
import { visit } from 'unist-util-visit';

const removePre: Pluggable = (/* options */) => {
  return function transformer(tree) {
    visit(tree, ['code'], function (node, index, parent) {
                                              // ^ type: any
      if (!parent) return;
      if (undefined === index) return;

      parent.children[index] = {
   // ^ type: never

parent should be Parent | undefined as reported by:

• [Types]: type of parent should be Parent #17
• and fixed in https://github.com/syntax-tree/unist-util-visit/pull/18/files

but somewhere alone the line the fix was lost.

Actual behavior

type is incorrect

Expected behavior

type is correct

Runtime

No response

Package manager

No response

Operating system

No response

Build and bundle tools

No response

[NullVoxPopuli]

Looks like the last version to have types for parent was v2

https://github.com/syntax-tree/unist-util-visit/blob/2.0.3/types/index.d.ts#L41 -- 5 years ago 🙈 ope

[NullVoxPopuli]

In particular, it looks like all the types exported from JS are a bit incorrect:
https://github.com/syntax-tree/unist-util-visit/blob/main/index.d.ts#L8-L9

export type {Visitor, BuildVisitor} from './lib/index.js'
//           ^ these don't exist in index.js

[JounQin]

It's here:

unist-util-visit/lib/index.js

Line 147 in 9121f99

* @callback Visitor

https://app.unpkg.com/unist-util-visit@5.0.0/files/lib/index.d.ts#L160-167

You should use something like https://github.com/alauda/doom/blob/61e06cf64a57a1017f8f6b604cee372bcfa263da/src/plugins/mermaid/remark-mermaid.ts#L5

[NullVoxPopuli]

hmm so my analysis is incorrect.

type is still goofy tho

https://github.com/alauda/doom/blob/61e06cf64a57a1017f8f6b604cee372bcfa263da/src/plugins/mermaid/remark-mermaid.ts#L5

I'll give this a go

[github-actions]

Hi! This was closed. Team: If this was fixed, please add phase/solved. Otherwise, please add one of the no/* labels.

[github-actions]

Hi! Thanks for reaching out! Because we treat issues as our backlog, we close issues that are questions since they don’t represent a task to be completed.

See our support docs for how and where to ask questions.

Thanks,
— bb

[NullVoxPopuli]

it works, thanks!

[wooorm]

Use 'code'. TS doesn’t infer arrays of strings as arrays of constants.
Or, do not use a test at all and use simple if-statements. TS can understand simple things best.
Please see https://unifiedjs.com/learn/recipe/tree-traversal-typescript/ and similar articles there!