fix(installation): don't misdetect npm/pipx installs in ~/.local/bin as curl (#129)

method() returned 'curl' for anything under ~/.local/bin before the
package-manager probes ran. But ~/.local/bin is also the target for
npm --prefix ~/.local, pipx, and other managers — so a 'npm i -g' install
there was upgraded with the curl script (installing a second copy or
clobbering the npm-managed one). Defer the .local/bin heuristic: let the
package-manager probes claim it first, and only fall back to 'curl' when
none do. (#36)

Author: aayambansal

backend/cli/src/installation/index.ts

@@ -61,7 +61,12 @@ export namespace Installation {
     if (process.execPath.includes(path.join(".openscience", "bin"))) return "curl"
     // legacy pre-rename curl installs lived under ~/.synsc/bin
     if (process.execPath.includes(path.join(".synsc", "bin"))) return "curl"
-    if (process.execPath.includes(path.join(".local", "bin"))) return "curl"
+    // ~/.local/bin is ALSO npm's target with `--prefix ~/.local`, pipx, and many
+    // package managers — so it's ambiguous. Defer it: let the package-manager
+    // probes below claim the install first, and only fall back to "curl" for
+    // .local/bin when none of them do (see after the loop). Otherwise a
+    // `npm i -g` into ~/.local was upgraded with the curl script.
+    const inLocalBin = process.execPath.includes(path.join(".local", "bin"))
     const exec = process.execPath.toLowerCase()
 
     const checks = [
@@ -114,6 +119,10 @@ export namespace Installation {
       }
     }
 
+    // No package manager claimed it — now honor the ambiguous ~/.local/bin as a
+    // curl install (the curl installer's default target).
+    if (inLocalBin) return "curl"
+
     return "unknown"
   }