fix(europepmc): read the journal name from journalInfo.journal.title#105
Merged
Merged
Conversation
The connector hardcodes resultType=core, whose records nest the journal under journalInfo.journal.title. toHit read a non-existent top-level journalTitle, so .filter(Boolean) silently dropped the undefined and the venue never appeared in the summary meta line (the fallback shown when a record has no abstract). Resolve the venue via a journalName() helper that reads the nested field and falls back to the top-level journalTitle for lite-shaped records.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The Europe PMC connector hardcodes
resultType=core, whose records nest the journal name underjournalInfo.journal.title.toHitread a non-existent top-leveljournalTitle, so.filter(Boolean)silently dropped theundefinedand the venue never appeared in the summary meta line (the fallback shown when a record has no abstract).Fix
Resolve the venue through a small
journalName()helper that reads the nestedjournalInfo.journal.titleand falls back to the top-leveljournalTitlefor older/lite-shaped records.Tests
Adds
test/science/europepmc.test.tscovering the nested field, the top-level fallback, nested-preferred precedence, and the no-journal case.