feat(codex): explicit ChatGPT-subscription vs API-key sign-in choice#109
Merged
Merged
Conversation
Selecting the OpenAI provider in `openscience keys add` now presents an explicit choice — 'ChatGPT subscription (Codex)' (the OAuth flow, no API key) vs 'OpenAI Platform API key' — instead of dropping straight into the API-key prompt with the Codex option only discoverable as a separate pinned list item. Users who look under 'OpenAI' now find the subscription path too. Extracts a shared runCodexAuthFlow() helper so `keys add` (ChatGPT branch) and `keys signin` reach the exact same OAuth flow, removing the duplicated plugin-lookup + handlePluginAuth wiring.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the Codex sign-in UX so choosing OpenAI is unambiguous.
Before
openscience keys add→ select OpenAI dropped straight into the API-key password prompt. The ChatGPT-subscription (Codex) path was only reachable via a separately-pinned top-of-list item, so a user who looked under "OpenAI" never saw it.After
Selecting OpenAI presents an explicit choice:
sk-…password prompt.The Codex path stays pinned at the top of the provider list too, so both entry points work. A shared
runCodexAuthFlow()helper backs bothkeys add(ChatGPT branch) andkeys signin, removing duplicated plugin-lookup/dispatch wiring. UX-only — the OAuth mechanics are unchanged.Verification
typecheck+prettierclean; full backend suite (905 tests) green.