fix: improved default sort value generation

mleutenegger · mleutenegger · commit e8ccf543df44 · 2024-04-19T16:42:09.000+02:00
diff --git a/src/Model/BaseItem.php b/src/Model/BaseItem.php
@@ -260,7 +260,7 @@ public function canCreate($member = null, $context = array())
     public function onBeforeWrite()
     {
         parent::onBeforeWrite();
-        if ($this->ID == 0) {
+        if (!$this->Sort) {
             $this->Sort = static::get()->max('Sort') + 1;
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -260,7 +260,7 @@ public function canCreate($member = null, $context = array())`
`260`	`260`	`public function onBeforeWrite()`
`261`	`261`	`{`
`262`	`262`	`parent::onBeforeWrite();`
`263`		`- if ($this->ID == 0) {`
	`263`	`+ if (!$this->Sort) {`
`264`	`264`	`$this->Sort = static::get()->max('Sort') + 1;`
`265`	`265`	`}`
`266`	`266`	`}`