???

Author: syntron

OMPython/ModelicaSystem.py

@@ -511,19 +511,18 @@ def getWorkDirectory(self) -> OMCPath:
         """
         return self._work_dir
 
-    def buildModel(self, variableFilter: Optional[str] = None):
-        variable_filter: Optional[str] = None
-        if variableFilter is not None:
-            variable_filter = variableFilter
+    def buildModel(self, filter_def: Optional[str] = None):
+        if filter_def is not None:
+            filter_def = filter_def
         elif self._variable_filter is not None:
-            variable_filter = self._variable_filter
+            filter_def = self._variable_filter
 
-        if variable_filter is not None:
-            varFilter = f'variableFilter="{variable_filter}"'
+        if filter_def is not None:
+            var_filter = f'variableFilter="{filter_def}"'
         else:
-            varFilter = 'variableFilter=".*"'
+            var_filter = 'variableFilter=".*"'
 
-        buildModelResult = self._requestApi(apiName="buildModel", entity=self._model_name, properties=varFilter)
+        buildModelResult = self._requestApi(apiName="buildModel", entity=self._model_name, properties=var_filter)
         logger.debug("OM model build result: %s", buildModelResult)
 
         # check if the executable exists ...
@@ -533,12 +532,12 @@ def buildModel(self, variableFilter: Optional[str] = None):
             modelname=self._model_name,
             timeout=5.0,
         )
-        # ... and outputs help for command help
+        # ... by running it - output help for command help
         om_cmd.arg_set(key="help", val="help")
         cmd_definition = om_cmd.definition()
         returncode = self._getconn.run_model_executable(cmd_run_data=cmd_definition)
         if returncode != 0:
-            raise ModelicaSystemError("Error on model executable test!")
+            raise ModelicaSystemError("Model executable not working!")
 
         xml_file = self._getconn.omcpath(buildModelResult[0]).parent / buildModelResult[1]
         self._xmlparse(xml_file=xml_file)