Skip to content

Commit cbe3900

Browse files
committed
Fix bug in update signal + remove django-extensions dependency
1 parent 62613cd commit cbe3900

4 files changed

Lines changed: 37 additions & 31 deletions

File tree

mqueue/migrations/0001_initial.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,10 @@
11
# -*- coding: utf-8 -*-
2-
# Generated by Django 1.11.5 on 2017-09-15 09:20
2+
# Generated by Django 1.11.5 on 2017-09-27 08:01
33
from __future__ import unicode_literals
44

55
from django.conf import settings
66
from django.db import migrations, models
77
import django.db.models.deletion
8-
import django_extensions.db.fields.json
98

109

1110
class Migration(migrations.Migration):
@@ -31,16 +30,16 @@ class Migration(migrations.Migration):
3130
('event_class', models.CharField(blank=True, max_length=120, verbose_name='Class')),
3231
('request', models.TextField(blank=True, verbose_name='Request')),
3332
('bucket', models.CharField(blank=True, max_length=60, verbose_name='Bucket')),
34-
('data', django_extensions.db.fields.json.JSONField(blank=True, default=dict, verbose_name='Data')),
33+
('data', models.CharField(blank=True, max_length=120, verbose_name='Data')),
3534
('scope', models.CharField(choices=[('superuser', 'Superuser'), ('staff', 'Staff'), ('users', 'Users'), ('public', 'Public')], default='superuser', max_length=18, verbose_name='Scope')),
3635
('content_type', models.ForeignKey(blank=True, null=True, on_delete=django.db.models.deletion.CASCADE, to='contenttypes.ContentType', verbose_name='Content type')),
3736
('user', models.ForeignKey(blank=True, null=True, on_delete=django.db.models.deletion.SET_NULL, related_name='+', to=settings.AUTH_USER_MODEL, verbose_name='User')),
3837
],
3938
options={
40-
'verbose_name': 'Event',
41-
'permissions': (('view_mevent', 'Can see Events'),),
4239
'ordering': ['-date_posted'],
4340
'verbose_name_plural': 'Events',
41+
'permissions': (('view_mevent', 'Can see Events'),),
42+
'verbose_name': 'Event',
4443
},
4544
),
4645
]

mqueue/models.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
from django.contrib.auth.models import User, AnonymousUser
88
from mqueue.utils import get_user, get_url, get_admin_url
99
from mqueue.hooks import dispatch
10-
from django_extensions.db.fields.json import JSONField
1110
from mqueue.conf import bcolors, NOSAVE
1211

1312

@@ -187,7 +186,8 @@ class MEvent(models.Model):
187186
request = models.TextField(blank=True, verbose_name=_(u'Request'))
188187
bucket = models.CharField(
189188
max_length=60, blank=True, verbose_name=_(u"Bucket"))
190-
data = JSONField(blank=True, verbose_name=_(u"Data"))
189+
data = models.CharField(max_length=120, blank=True,
190+
verbose_name=_(u"Data"))
191191
# manager
192192
scope = models.CharField(max_length=18, choices=SCOPE,
193193
default=SCOPE[0][0], verbose_name=_(u"Scope"))

mqueue/signals.py

Lines changed: 25 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55

66
def mmessage_create(sender, instance, created, **kwargs):
7-
if created:
7+
if created is True:
88
# try to get the user
99
user = get_user(instance)
1010
# try to get the object name
@@ -43,27 +43,28 @@ def mmessage_delete(sender, instance, **kwargs):
4343

4444

4545
def mmessage_save(sender, instance, created, **kwargs):
46-
# try to get the user
47-
user = get_user(instance)
48-
if 'name' not in kwargs.keys():
49-
# try to get the object name
50-
obj_name = get_object_name(instance, user)
51-
else:
52-
obj_name = kwargs('name')
53-
# try to get the admin url
54-
admin_url = get_admin_url(instance)
55-
event_str = ' edited'
56-
if created:
57-
event_str = ' created'
58-
event_class = instance.__class__.__name__ + event_str
59-
# create event
60-
MEvent.objects.create(
61-
model=instance.__class__,
62-
name=obj_name,
63-
obj_pk=instance.pk,
64-
user=user,
65-
url=get_url(instance),
66-
admin_url=admin_url,
67-
event_class=event_class,
68-
)
46+
if created is False:
47+
# try to get the user
48+
user = get_user(instance)
49+
if 'name' not in kwargs.keys():
50+
# try to get the object name
51+
obj_name = get_object_name(instance, user)
52+
else:
53+
obj_name = kwargs('name')
54+
# try to get the admin url
55+
admin_url = get_admin_url(instance)
56+
event_str = ' edited'
57+
if created:
58+
event_str = ' created'
59+
event_class = instance.__class__.__name__ + event_str
60+
# create event
61+
MEvent.objects.create(
62+
model=instance.__class__,
63+
name=obj_name,
64+
obj_pk=instance.pk,
65+
user=user,
66+
url=get_url(instance),
67+
admin_url=admin_url,
68+
event_class=event_class,
69+
)
6970
return

mqueue/views.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,7 @@
11
# -*- coding: utf-8 -*-
2+
3+
from django.views.generic import TemplateView
4+
5+
6+
class EventsDash(TemplateView):
7+
template_name = "mqueue/dashboard.html"

0 commit comments

Comments
 (0)