fix: skip re-sanitization of already-sanitized UTXOs in fetchAndSanit…#15
Open
ipseonet wants to merge 1 commit into
Open
fix: skip re-sanitization of already-sanitized UTXOs in fetchAndSanit…#15ipseonet wants to merge 1 commit into
ipseonet wants to merge 1 commit into
Conversation
…izeUTXOs When utxos are passed in already sanitized (e.g. when using WIF signing without a Signer), fetchAndSanitizeUTXOs was re-sanitizing them via sanitizeBlockbookUTXOs. This caused txId to be lost because the re- sanitization reads utxo.txid (lowercase) which is undefined on already- sanitized objects that use camelCase txId. This broke PSBT construction for WIF signers with the error: 'Invalid arguments for Psbt.addInput. Requires single object with at least [hash] and [index]' Fix: detect already-sanitized UTXOs by checking for the presence of .utxos array with txId fields, and skip re-sanitization in that case. Fixes: syscoin#14
Member
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Member
|
@ipseonet can you describe your organization and how you use it, who are your clients? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #14
When
utxosare passed in already sanitized (e.g. when using WIF signing without a Signer),fetchAndSanitizeUTXOswas incorrectly re-sanitizing them viasanitizeBlockbookUTXOs.This caused
txIdto be silently lost becausesanitizeBlockbookUTXOsreadsutxo.txid(lowercase) which isundefinedon already-sanitized objects that use camelCasetxId.Error
Invalid arguments for Psbt.addInput. Requires single object with at least [hash] and [index]
Fix
Detect already-sanitized UTXOs by checking for the presence of a
.utxosarray withtxIdfields, and skip re-sanitization in that case.Testing
Verified by successfully building and broadcasting a
syscoinBurnToAssetAllocationtransaction using WIF signing on Tanenbaum testnet.TXID:
f131e672f31ef490c3e92cd78ee844abae711ff3d66b5383121d8e6e90b1e349