Clean up...

Author: dangaiden

internal/infra/mcp/tools/tool_k8s_list_top_unavailable_pods.go

@@ -100,10 +100,6 @@ func buildTopUnavailablePodsQuery(limit int, clusterName, namespaceName, workloa
 	}
 
 	if !tw.IsZero() {
-		// Sysdig-canonical pattern (backend/.../advisories.json:206 — WorkloadReplicasMismatch):
-		// min_over_time(kube_workload_status_unavailable[W]) >= 1 — workload was unavailable
-		// for every scrape tick in the window. Simpler and more accurate than computing
-		// desired - ready across the window.
 		filtersStr := strings.Join(baseFilters, ",")
 		return fmt.Sprintf("topk(%d, sum by (kube_cluster_name, kube_namespace_name, kube_workload_name) (min_over_time(kube_workload_status_unavailable{%s}%s) >= 1))",
 			limit, filtersStr, tw.RangeSelector())

internal/infra/mcp/tools/tool_k8s_list_workloads.go

@@ -118,9 +118,6 @@ func buildKubeWorkloadInfoQuery(status, clusterName, namespaceName, workloadName
 	}
 
 	if !tw.IsZero() {
-		// For "unavailable" the canonical Sysdig idiom keeps a > 0 guard to drop
-		// workloads that were healthy all window (see advisories.json:206).
-		// For desired/ready/running, zero is a legitimate observed value.
 		wrapped := fmt.Sprintf("max_over_time(%s%s)", metric, tw.RangeSelector())
 		if status == "unavailable" {
 			return wrapped + " > 0"

internal/infra/mcp/tools/tools_suite_test.go

@@ -15,9 +15,6 @@ func TestTools(t *testing.T) {
 	RunSpecs(t, "Tools Suite")
 }
 
-// newWindowedQueryParams constructs the GetQueryV1Params value that a windowed tool
-// invocation is expected to produce: Query string, Time = end.Unix() via FromQueryTime1,
-// and a 60s Timeout.
 func newWindowedQueryParams(query string, end time.Time) sysdig.GetQueryV1Params {
 	var qt sysdig.Time
 	Expect(qt.FromQueryTime1(end.Unix())).To(Succeed())
@@ -29,8 +26,6 @@ func newWindowedQueryParams(query string, end time.Time) sysdig.GetQueryV1Params
 	}
 }
 
-// mergeLimit attaches a Limit field to an existing GetQueryV1Params value.
-// Used by tools that set params.Limit (memory_*, count_pods, underutilized_*).
 func mergeLimit(p sysdig.GetQueryV1Params, limit int) sysdig.GetQueryV1Params {
 	lq := sysdig.LimitQuery(limit)
 	p.Limit = &lq

internal/infra/mcp/tools/utils.go

@@ -57,8 +57,6 @@ func RequiredPermissionsFromTool(tool mcp.Tool) []string {
 	return requiredPermissions
 }
 
-// --- Time-window support for k8s_list_* Monitor tools --------------------
-
 const (
 	windowedQueryTimeout  = "60s"
 	timeParamStart        = "start"
@@ -67,32 +65,23 @@ const (
 	endParamDescription   = "End of the query window as an RFC3339 timestamp (e.g. 2026-04-01T01:00:00Z). Requires start. If in the future, clamped to now."
 )
 
-// TimeWindow is a resolved, validated [Start, End] pair for a historical PromQL query.
-// A zero-value TimeWindow means no window was requested — the caller should emit its
-// existing instant query and leave GetQueryV1Params.Time nil.
 type TimeWindow struct {
 	Start time.Time
 	End   time.Time
 }
 
-// IsZero reports whether no time window was requested.
 func (w TimeWindow) IsZero() bool {
 	return w.Start.IsZero() && w.End.IsZero()
 }
 
-// RangeSelector returns the PromQL range-selector literal for this window, e.g. "[3600s]".
 func (w TimeWindow) RangeSelector() string {
 	return fmt.Sprintf("[%ds]", int64(w.End.Sub(w.Start).Seconds()))
 }
 
-// WindowSeconds returns the duration of the window in whole seconds.
 func (w TimeWindow) WindowSeconds() int64 {
 	return int64(w.End.Sub(w.Start).Seconds())
 }
 
-// EvalTime returns a *sysdig.Time suitable for GetQueryV1Params.Time. The value is
-// the End instant as unix seconds — the native format accepted by Sysdig's internal
-// PromQL stack (confirmed against backend PrometheusFacadeController.java:113).
 func (w TimeWindow) EvalTime() (*sysdig.Time, error) {
 	if w.IsZero() {
 		return nil, nil
@@ -104,9 +93,6 @@ func (w TimeWindow) EvalTime() (*sysdig.Time, error) {
 	return &qt, nil
 }
 
-// ApplyToParams sets Time and, for windowed queries, Timeout on params.
-// It consolidates the three-step boilerplate (EvalTime, set Time, set Timeout)
-// that every k8s_list_* handler would otherwise repeat.
 func (w TimeWindow) ApplyToParams(params *sysdig.GetQueryV1Params) error {
 	evalTime, err := w.EvalTime()
 	if err != nil {
@@ -120,23 +106,15 @@ func (w TimeWindow) ApplyToParams(params *sysdig.GetQueryV1Params) error {
 	return nil
 }
 
-// WithTimeWindowParams returns a ToolOption that declares the shared "start" and "end"
-// RFC3339 parameters on a tool.
 func WithTimeWindowParams() mcp.ToolOption {
 	return func(t *mcp.Tool) {
 		mcp.WithString(timeParamStart, mcp.Description(startParamDescription))(t)
 		mcp.WithString(timeParamEnd, mcp.Description(endParamDescription))(t)
 	}
 }
 
-// ParseTimeWindow reads "start" and "end" from the request, validates them, and returns
-// the resolved TimeWindow.
-//
-//   - Both absent:       returns zero-value TimeWindow, nil error.
-//   - end without start: error ("end requires start").
-//   - start without end: end = clk.Now().
-//   - invalid RFC3339:   error naming the bad field.
-//   - end <= start:      error.
+// Reads "start" and "end" from the request, validates them, and return the resolved TimeWindow.
+
 func ParseTimeWindow(request mcp.CallToolRequest, clk clock.Clock) (TimeWindow, error) {
 	startStr := mcp.ParseString(request, timeParamStart, "")
 	endStr := mcp.ParseString(request, timeParamEnd, "")

internal/infra/mcp/tools/utils_test.go

@@ -22,7 +22,7 @@ var _ = Describe("ParseTimeWindow", func() {
 	BeforeEach(func() {
 		ctrl = gomock.NewController(GinkgoT())
 		mockClock = mocks_clock.NewMockClock(ctrl)
-		now = time.Date(2026, time.April, 16, 12, 0, 0, 500000000, time.UTC) // has sub-second part
+		now = time.Date(2026, time.April, 16, 12, 0, 0, 500000000, time.UTC)
 	})
 
 	AfterEach(func() { ctrl.Finish() })
@@ -102,8 +102,6 @@ var _ = Describe("ParseTimeWindow", func() {
 	})
 
 	It("truncates sub-second precision from now so RangeSelector never emits [0s]", func() {
-		// now has 500ms; start is in the same second — after truncation end == start,
-		// which must be rejected rather than silently producing [0s].
 		mockClock.EXPECT().Now().Return(now)
 		_, err := tools.ParseTimeWindow(makeRequest(map[string]any{
 			"start": "2026-04-16T12:00:00Z",