chore(tools): remove interval deprecation warnings and dead requestHasArg helper

Author: dangaiden

internal/infra/mcp/tools/README.md

@@ -67,10 +67,6 @@ Validation rules (helper: `utils.go`):
 Windowed queries carry a 60 s client-side PromQL `Timeout` to fail fast before the
 Sysdig edge proxy's own 80–90 s cut-off.
 
-For `k8s_list_top_http_errors_in_pods` and `k8s_list_top_network_errors_in_pods`,
-`interval` (e.g. `"1h"`) is still supported as a relative-duration shorthand; `start`/`end`
-take precedence when both are provided.
-
 # Adding a New Tool
 
 1.  **See other tools:** Check how other tools are implemented so you can have the context on how they should look like.

internal/infra/mcp/tools/tool_k8s_list_top_http_errors_in_pods.go

@@ -28,7 +28,7 @@ func NewK8sListTopHttpErrorsInPods(sysdigClient sysdig.ExtendedClientWithRespons
 
 func (t *K8sListTopHttpErrorsInPods) RegisterInServer(s *server.MCPServer) {
 	tool := mcp.NewTool("k8s_list_top_http_errors_in_pods",
-		mcp.WithDescription("Lists the pods with the highest rate of HTTP 4xx and 5xx errors over a time window, allowing filtering by cluster, namespace, workload type, and workload name. Pass start/end (RFC3339) for an explicit window, or interval for a relative duration."),
+		mcp.WithDescription("Lists the pods with the highest rate of HTTP 4xx and 5xx errors over a time window, allowing filtering by cluster, namespace, workload type, and workload name. Pass start/end (RFC3339) to specify the window. The legacy 'interval' param is retained for backward compatibility; start/end take precedence when both are provided."),
 		mcp.WithString("interval", mcp.Description("Time interval for the query (e.g. '1h', '30m'). Default is '1h'. Ignored when start/end are provided.")),
 		mcp.WithString("cluster_name", mcp.Description("The name of the cluster to filter by.")),
 		mcp.WithString("namespace_name", mcp.Description("The name of the namespace to filter by.")),

internal/infra/mcp/tools/tool_k8s_list_top_network_errors_in_pods.go

@@ -28,7 +28,7 @@ func NewK8sListTopNetworkErrorsInPods(sysdigClient sysdig.ExtendedClientWithResp
 
 func (t *K8sListTopNetworkErrorsInPods) RegisterInServer(s *server.MCPServer) {
 	tool := mcp.NewTool("k8s_list_top_network_errors_in_pods",
-		mcp.WithDescription("Shows the top network errors by pod over a time window, aggregated by cluster, namespace, workload type, and workload name. The result is an average rate of network errors per second. Pass start/end (RFC3339) for an explicit window, or interval for a relative duration."),
+		mcp.WithDescription("Shows the top network errors by pod over a time window, aggregated by cluster, namespace, workload type, and workload name. The result is an average rate of network errors per second. Pass start/end (RFC3339) to specify the window. The legacy 'interval' param is retained for backward compatibility; start/end take precedence when both are provided."),
 		mcp.WithString("interval", mcp.Description("Time interval for the query (e.g. '1h', '30m'). Default is '1h'. Ignored when start/end are provided.")),
 		mcp.WithString("cluster_name", mcp.Description("The name of the cluster to filter by.")),
 		mcp.WithString("namespace_name", mcp.Description("The name of the namespace to filter by.")),

internal/infra/mcp/tools/utils.go

@@ -175,13 +175,3 @@ func ParseTimeWindow(request mcp.CallToolRequest, clk clock.Clock) (TimeWindow,
 	return TimeWindow{Start: start, End: end}, nil
 }
 
-// requestHasArg reports whether the caller explicitly supplied the named argument
-// (distinguishes "user passed empty string" from "user didn't pass the key at all").
-func requestHasArg(request mcp.CallToolRequest, name string) bool {
-	args, ok := request.Params.Arguments.(map[string]any)
-	if !ok {
-		return false
-	}
-	_, present := args[name]
-	return present
-}