Add Sysdig SDK#2
Conversation
S3B4SZ17
force-pushed
the
add-sysdig-sdk
branch
2 times, most recently
from
304c06e to
7c11d2e
Compare
Signed-off-by: S3B4SZ17 <sebastian.zumbado@sysdig.com>
|
|
||
| - name: Run ruff | ||
| run: | | ||
| uvx ruff check --fix --config ruff.toml |
There was a problem hiding this comment.
Let's extract all those targets into a makefile so it's easier to maintain and execute locally.
make lintmake test
...
| run: | | ||
| uv run pytest --cov=. --cov-report=xml | ||
|
|
||
| - name: Extract version |
There was a problem hiding this comment.
Let's split this into a different job that depends on the previous. This way we can execute the previous one locally with act.
| - id: ruff-format | ||
| name: Ruff Format | ||
| description: Format code with ruff. | ||
| entry: bash -c 'uvx ruff format --config ruff.toml' |
There was a problem hiding this comment.
In here we could use the previous mentioned make fmt
| entry: bash -c 'uvx ruff format --config ruff.toml' | ||
| language: system | ||
| stages: ["commit", "push"] | ||
| - id: ruff-check |
| # the repo. Unless a later match takes precedence, | ||
| # @S3B4SZ17 @alecron and @sysdiglabs/sysdig-training will be requested for | ||
| # review when someone opens a pull request. | ||
| * @S3B4SZ17 @alecron @sysdiglabs/sysdig-training |
There was a problem hiding this comment.
You don't need to specify the single contributors and just leave the team. It's easier to maintain if there are movements in the org.
| @@ -0,0 +1,287 @@ | |||
| # Exclude a variety of commonly ignored directories. | |||
There was a problem hiding this comment.
IDK if this is required. Let's check without it, because it eases the maintenance.
There was a problem hiding this comment.
Here just following the official doc and excluding the common packages https://docs.astral.sh/ruff/configuration/ I got the list of lints to use from other big OSS projects so I think since the file has a good amount of lines leave it on its own.
| @@ -0,0 +1,287 @@ | |||
| # Exclude a variety of commonly ignored directories. | |||
There was a problem hiding this comment.
Here just following the official doc and excluding the common packages https://docs.astral.sh/ruff/configuration/ I got the list of lints to use from other big OSS projects so I think since the file has a good amount of lines leave it on its own.
* Adding CI/CD pipeline * Updating overall format and standards Co-authored-by: S3B4SZ17 <sebastian.zumbado@sysdig.com> Co-authored-by: Fede Barcelona <fede_rico_94@hotmail.com> Signed-off-by: S3B4SZ17 <sebastian.zumbado@sysdig.com>
4 participants
No description provided.