Merged
Conversation
ombellare
reviewed
Mar 17, 2025
Contributor
ombellare
left a comment
ombellare
left a comment
There was a problem hiding this comment.
Just a couple of comments but overall LGTM!
| return diag.FromErr(err) | ||
| } | ||
|
|
||
| d.SetId(fmt.Sprintf("count_%s", ruleName)) |
Contributor
There was a problem hiding this comment.
Should the id be count__ruleName__ruleType (with double underscores)?
| ruleIndexObj, ok := d.GetOk("index") | ||
| ruleIndex := 0 | ||
| if ok { | ||
| ruleIndex = ruleIndexObj.(int) |
Contributor
There was a problem hiding this comment.
Nit: Could we use the ruleIndex, ok form here to avoid panic since we are not enforcing a schema on this field?
kmvachhani
requested review from
draraksysdig,
filiptubic and
mbarbieri
as code owners
ombellare
approved these changes
Mar 17, 2025
Contributor
ombellare
left a comment
ombellare
left a comment
There was a problem hiding this comment.
LGTM! Thanks for addressing my nits :)
draraksysdig
approved these changes
Mar 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add data source and resource for missing stateful detection elements, update cache GHA version