Skip to content

fix(zones): use IBM client for platform zones #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vojindj merged 1 commit into from
Apr 15, 2025
Merged

fix(zones): use IBM client for platform zones #625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sysdig/data_source_sysdig_secure_zone_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build tf_acc_sysdig_secure || tf_acc_onprem_secure
//go:build tf_acc_sysdig_secure || tf_acc_onprem_secure || tf_acc_ibm_secure

package sysdig_test

Expand All @@ -13,7 +13,7 @@ import (

func TestAccDataSourceSysdigSecureZone(t *testing.T) {
resource.ParallelTest(t, resource.TestCase{
PreCheck: preCheckAnyEnv(t, SysdigSecureApiTokenEnv),
PreCheck: preCheckAnyEnv(t, SysdigSecureApiTokenEnv, SysdigIBMSecureAPIKeyEnv),
ProviderFactories: map[string]func() (*schema.Provider, error){
"sysdig": func() (*schema.Provider, error) {
return sysdig.Provider(), nil
Expand Down
16 changes: 15 additions & 1 deletion sysdig/resource_sysdig_secure_zone.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,5 +191,19 @@ func fromZoneScopesResponse(scopes []v2.ZoneScope) []interface{} {
}

func getZoneClient(clients SysdigClients) (v2.ZoneInterface, error) {
return clients.sysdigSecureClientV2()
var client v2.ZoneInterface
var err error
switch clients.GetClientType() {
case IBMSecure:
client, err = clients.ibmSecureClient()
if err != nil {
return nil, err
}
default:
client, err = clients.sysdigSecureClientV2()
if err != nil {
return nil, err
}
}
return client, nil
}
4 changes: 2 additions & 2 deletions sysdig/resource_sysdig_secure_zone_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//go:build tf_acc_sysdig_secure || tf_acc_onprem_secure
//go:build tf_acc_sysdig_secure || tf_acc_onprem_secure || tf_acc_ibm_secure

package sysdig_test

Expand All @@ -16,7 +16,7 @@ func TestAccSysdigZone_basic(t *testing.T) {
zoneDescription := "Test Zone Description"

resource.ParallelTest(t, resource.TestCase{
PreCheck: preCheckAnyEnv(t, SysdigSecureApiTokenEnv),
PreCheck: preCheckAnyEnv(t, SysdigSecureApiTokenEnv, SysdigIBMSecureAPIKeyEnv),
ProviderFactories: map[string]func() (*schema.Provider, error){
"sysdig": func() (*schema.Provider, error) {
return sysdig.Provider(), nil
Expand Down
Loading