chore(notification-channels): Make Slack webhook URL fields sensitive#631
Merged
dbonf merged 1 commit intosysdiglabs:masterfrom Apr 28, 2025
Merged
Conversation
akahenry
requested review from
antonio-cuomo,
dbonf,
dkutsanov and
michelevergnano
as code owners
dbonf
approved these changes
Apr 28, 2025
Collaborator
dbonf
left a comment
dbonf
left a comment
There was a problem hiding this comment.
thanks for this contribution, it makes totally sense, so, lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slack webhook URLs are sensitive according to Slack documentation (https://api.slack.com/messaging/webhooks):
This PR makes them sensitive in Terraform as well so they don't get sent to logs and unexpectedly exposed.