feat!: deprecate cloudsec resources

[jose-pablo-camacho]

This pull request deprecates the resource responsible for making cloudsec calls in the Sysdig Terraform provider.

Specifically, it removes the sysdig_secure_cloud_account resource and its related implementation, tests, and documentation. The changes include deleting the resource file, its test file, and the corresponding documentation, as well as cleaning up references in the provider’s registration and internal client code. This is part of a broader effort to phase out legacy cloudsec resource management from the provider.

[jose-pablo-camacho]

@airadier @mateobur @tembleking - looks like I need your reviews as codeowner

[tembleking]

Blocking the merge of this PR since this is removing a resource without a previous deprecation and replacement.

[tembleking]

We cannot just remove resources from the provider, because those may be in use by some customer. First you need to mark it as deprecated pointing to a replacement and then ensure no one else is using it.

[tembleking]

You can use the field DeprecationMessage within schema.Resource like:

DeprecationMessage: "This resource is deprecated. Please use X resource instead.",

That will mark the resource as deprecated.

[jose-pablo-camacho]

Deprecation of sysdig_secure_cloud_account resource

This PR deprecates the sysdig_secure_cloud_account resource. This change is considered a breaking change for very old customer installations that might try to upgrade the provider. However, it is not expected to impact current users due to the following reasons:

• Limited Usage: The resource has only been used within legacy Terraform modules (terraform-aws-secure-for-cloud, Azure, and GCP), which have been deprecated for over a year.
• No Current Usage: We have confirmed that no one should be actively using this resource, as it is tied to a deprecated type of onboarding.
• Pinned Provider Versions: The deprecated modules pin the Sysdig provider to older versions (~1.x), which include this resource since the underlying API is not yet deprecated. Therefore, current users of those modules will not encounter this breaking change unless they explicitly upgrade their provider version significantly.
• No On-Premise Usage: The Terraform resource was not used by on-premise installations, as the cloudbench submodule (the only one that used this resource) was not supported for on-premise.

Impact and Solution for Potential Issues:

For any really old customer installations that attempt to upgrade their provider and encounter issues due to this deprecation, the expectation is to follow the documentation provided in the PS support steps: Terraform Sysdig Provider – Deprecation of sysdig_secure_cloud_account resource (v2.x Breaking Change).

The recommended solutions are:

• Redeploy using the new onboarding process.
• Pin an older provider version if they absolutely do not wish to migrate.

Given that current snippets point to older versions, users upgrading will be moving up two major versions, making breaking changes expected. The ultimate solution for these users is to migrate to the new onboarding process, as the deprecated methods will no longer be supported.

@ravinadhruve10 @tembleking