Remove deprecated list matching rule tests and update documentation#683
Merged
rosenbloomb-sysdig merged 3 commits intomasterfrom Dec 17, 2025
Merged
Remove deprecated list matching rule tests and update documentation#683rosenbloomb-sysdig merged 3 commits intomasterfrom
rosenbloomb-sysdig merged 3 commits intomasterfrom
Conversation
rosenbloomb-sysdig
requested review from
airadier,
mateobur and
tembleking
as code owners
harshampatel-sysdig
previously approved these changes
Dec 16, 2025
This reverts commit b5bd6d9.
Add t.Skip() statements to all list matching rule tests (container, filesystem, network, process, syscall) for both resources and data sources. This preserves the test code for future reference while clearly marking these tests as skipped due to deprecation. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
airadier
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sysdig_secure_rule_falcoBackground
List matching rules have been deprecated in favor of Falco rules. These tests were failing because the underlying functionality is no longer supported.
Changes
Tests Removed (10 files, -768 lines)
Data Source Tests:
data_source_sysdig_secure_rule_container_test.godata_source_sysdig_secure_rule_filesystem_test.godata_source_sysdig_secure_rule_network_test.godata_source_sysdig_secure_rule_process_test.godata_source_sysdig_secure_rule_syscall_test.goResource Tests:
resource_sysdig_secure_rule_container_test.goresource_sysdig_secure_rule_filesystem_test.goresource_sysdig_secure_rule_network_test.goresource_sysdig_secure_rule_process_test.goresource_sysdig_secure_rule_syscall_test.goDocumentation Updated (10 files, +20 lines)
Added deprecation warnings to all list matching rule documentation files directing users to use
sysdig_secure_rule_falcoinstead.Test Coverage
Existing Falco rule tests (
data_source_sysdig_secure_rule_falco_test.goandresource_sysdig_secure_rule_falco_test.go) provide sufficient coverage for runtime security rules going forward.🤖 Generated with Claude Code