Skip to content

fix(test): use unique names in tests to prevent flakiness #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tembleking merged 2 commits into from
Feb 6, 2026
Merged

fix(test): use unique names in tests to prevent flakiness #697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7fde40
fix(test): use unique names in managed ruleset test to prevent flakiness
tembleking Feb 6, 2026
31111b5
fix(test): use unique names in custom policy data source test
tembleking Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions sysdig/data_source_sysdig_secure_custom_policy_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
package sysdig_test

import (
"fmt"
"os"
"testing"

Expand Down Expand Up @@ -36,16 +37,16 @@ func TestAccCustomPolicyDataSource(t *testing.T) {
}

func customPolicyDataSource(name string) string {
return `
return fmt.Sprintf(`
resource "sysdig_secure_custom_policy" "sample" {
name = "%s"
name = "Test Custom Policy %s"
description = "Test Description"
enabled = true
}

data "sysdig_secure_custom_policy" "example" {
name = "%s"
depends_on=[ sysdig_secure_custom_policy.sample ]
name = "Test Custom Policy %s"
depends_on = [sysdig_secure_custom_policy.sample]
}
`
`, name, name)
}
51 changes: 25 additions & 26 deletions sysdig/resource_sysdig_secure_managed_ruleset_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,14 @@ import (
"os"
"testing"

"github.com/hashicorp/terraform-plugin-sdk/v2/helper/acctest"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"

"github.com/draios/terraform-provider-sysdig/sysdig"
)

func TestAccManagedRuleset(t *testing.T) {
rText := func() string { return acctest.RandStringFromCharSet(10, acctest.CharSetAlphaNum) }
rText := randomText(10)

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() {
Expand All @@ -30,24 +29,24 @@ func TestAccManagedRuleset(t *testing.T) {
},
Steps: []resource.TestStep{
{
Config: managedRulesetWithoutNotificationChannels(),
Config: managedRulesetWithoutNotificationChannels(rText),
},
{
ResourceName: "sysdig_secure_managed_ruleset.sample",
ImportState: true,
ImportStateVerify: true,
},
{
Config: managedRulesetWithoutActions(rText()),
Config: managedRulesetWithoutActions(rText),
},
{
Config: managedRuleset(rText()),
Config: managedRuleset(rText),
},
{
Config: managedRulesetWithMinimumConfiguration(),
Config: managedRulesetWithMinimumConfiguration(rText),
},
{
Config: managedRulesetWithKillAction(),
Config: managedRulesetWithKillAction(rText),
Destroy: true,
},
},
Expand All @@ -58,7 +57,7 @@ func managedRuleset(name string) string {
return fmt.Sprintf(`
%s
resource "sysdig_secure_managed_ruleset" "sample" {
name = "Sysdig Runtime Threat Detection (Copy)"
name = "Sysdig Runtime Threat Detection - %s"
description = "Test Description"
inherited_from {
name = "Sysdig Runtime Threat Detection"
Expand All @@ -77,17 +76,17 @@ resource "sysdig_secure_managed_ruleset" "sample" {
name = "testcapture"
}
}

notification_channels = [sysdig_secure_notification_channel_email.sample_email.id]
}
`, secureNotificationChannelEmailWithName(name))
`, secureNotificationChannelEmailWithName(name), name)
}

func managedRulesetWithoutActions(name string) string {
return fmt.Sprintf(`
%s
resource "sysdig_secure_managed_ruleset" "sample" {
name = "Sysdig Runtime Threat Detection (Copy)"
name = "Sysdig Runtime Threat Detection - %s"
description = "Test Description"
inherited_from {
name = "Sysdig Runtime Threat Detection"
Expand All @@ -99,16 +98,16 @@ resource "sysdig_secure_managed_ruleset" "sample" {
runbook = "https://sysdig.com"

actions {}

notification_channels = [sysdig_secure_notification_channel_email.sample_email.id]
}
`, secureNotificationChannelEmailWithName(name))
`, secureNotificationChannelEmailWithName(name), name)
}

func managedRulesetWithoutNotificationChannels() string {
return `
func managedRulesetWithoutNotificationChannels(name string) string {
return fmt.Sprintf(`
resource "sysdig_secure_managed_ruleset" "sample" {
name = "Sysdig Runtime Threat Detection (Copy)"
name = "Sysdig Runtime Threat Detection - %s"
description = "Test Description"
inherited_from {
name = "Sysdig Runtime Threat Detection"
Expand All @@ -126,27 +125,27 @@ resource "sysdig_secure_managed_ruleset" "sample" {
seconds_after_event = 10
name = "testcapture"
}
}
}`
}
}`, name)
}

func managedRulesetWithMinimumConfiguration() string {
return `
func managedRulesetWithMinimumConfiguration(name string) string {
return fmt.Sprintf(`
resource "sysdig_secure_managed_ruleset" "sample" {
name = "Sysdig Runtime Threat Detection (Copy)"
name = "Sysdig Runtime Threat Detection - %s"
description = "Test Description"
inherited_from {
name = "Sysdig Runtime Threat Detection"
type = "falco"
}
enabled = true
}`
}`, name)
}

func managedRulesetWithKillAction() string {
return `
func managedRulesetWithKillAction(name string) string {
return fmt.Sprintf(`
resource "sysdig_secure_managed_ruleset" "sample" {
name = "Sysdig Runtime Threat Detection (Copy)"
name = "Sysdig Runtime Threat Detection - %s"
description = "Test Description"
inherited_from {
name = "Sysdig Runtime Threat Detection"
Expand All @@ -160,5 +159,5 @@ resource "sysdig_secure_managed_ruleset" "sample" {
actions {
container = "kill"
}
}`
}`, name)
}
Loading