feat(response actions) Onboarding full validation [SSPROD-64190]#717
Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tembleking
left a comment
tembleking
left a comment
There was a problem hiding this comment.
Hey! Since the metadata is handled generically via protojson.Unmarshal, these new fields work automatically, nice. But would it be possible to add a test that verifies validation_role_name and validation_role survive a round-trip through serialization? That way if a future proto regen accidentally drops them, we'd catch it before it becomes a breaking change for users. If it's not easy to test here, totally fine, just figured it's worth asking.
tembleking
left a comment
tembleking
left a comment
There was a problem hiding this comment.
Not easy to test, so let's just merge it.
No description provided.