fix(monitor-secure-alerts): replace urls in prometheus alert-manager tests#725
Merged
the-pierfra merged 1 commit intomasterfrom Apr 15, 2026
Merged
Conversation
…theus alert manager tests Backend now validates DNS resolution on notification channel URLs at creation time. testurl.com no longer resolves, causing test failures. example.com is IANA-reserved (RFC 2606) and guaranteed stable.
the-pierfra
requested review from
a team,
DagDigg,
Shadow649,
dbonf,
dkutsanov,
michelevergnano and
vojindj
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Prometheus Alertmanager notification channel acceptance tests to use a stable, DNS-resolving placeholder domain so channel creation no longer fails due to URL validation.
Changes:
- Replaced
https://testurl.com/xxxwithhttps://example.com/testin Secure resource acceptance tests. - Replaced
https://testurl.com/xxxwithhttps://example.com/testin Monitor resource acceptance tests. - Updated both Secure and Monitor data source acceptance tests to use the same stable URL.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sysdig/resource_sysdig_secure_notification_channel_prometheus_alert_manager_test.go | Updates placeholder URL in Secure Prometheus Alertmanager resource acceptance tests. |
| sysdig/resource_sysdig_monitor_notification_channel_prometheus_alert_manager_test.go | Updates placeholder URL in Monitor Prometheus Alertmanager resource acceptance tests. |
| sysdig/data_source_sysdig_secure_notification_channel_prometheus_alert_manager_test.go | Updates placeholder URL in Secure Prometheus Alertmanager data source acceptance test config. |
| sysdig/data_source_sysdig_monitor_notification_channel_prometheus_alert_manager_test.go | Updates placeholder URL in Monitor Prometheus Alertmanager data source acceptance test config. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dbonf
approved these changes
Apr 15, 2026
the-pierfra
deleted the
fix/SMPROD-20417-prometheus-alert-manager-test-url
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates Prometheus Alertmanager notification channel acceptance tests to use a stable, DNS-resolving placeholder domain so channel creation no longer fails due to URL validation.
Changes:
https://testurl.com/xxxwithhttps://example.com/testin Secure resource acceptance tests.https://testurl.com/xxxwithhttps://example.com/testin Monitor resource acceptance tests.Updated both Secure and Monitor data source acceptance tests to use the same stable URL.