fix(iac): unstuck scan when no problems were found (#21)

Author: tembleking

flake.nix

@@ -70,7 +70,7 @@
               shellHook = ''
                 npm ci
               '';
-              buildInputs = [
+              packages = [
                 vscode
                 nodejs
                 typescript

src/config/configScanner.ts

@@ -27,7 +27,7 @@ export const ENDPOINT_LABELS: { [key: string]: string } = {
     "https://app.me2.sysdig.com": "ME Central (GCP)"
 };
 
-export const SCANNER_VERSION : string = '1.13.0';
+export const SCANNER_VERSION : string = '1.22.1';
 const SCANNER_BASE_URL : string = 'https://download.sysdig.com/scanning/bin/sysdig-cli-scanner/';
 const SCANNER_BINARY_NAME : string = 'sysdig-cli-scanner';
 
@@ -188,4 +188,4 @@ export async function storeCredentials(context: vscode.ExtensionContext) {
     await context.secrets.store("sysdig-vscode-ext.secureEndpoint", secureEndpoint);
     await context.secrets.store("sysdig-vscode-ext.secureAPIToken", secureAPIToken);
     vscode.window.showInformationMessage('Successfully stored Sysdig Secure credentials');
-}
+}

src/runners/iacScanRunner.ts

@@ -21,15 +21,15 @@ interface commandIACOptions {
 
 interface ScanData {
     result: {
-        findings: Array<{
-            severity: string;
-            resources: Array<{
-                source: string;
-                location: string;
-                type: string;
-                name: string;
+        findings?: Array<{
+            severity?: string;
+            resources?: Array<{
+                source?: string;
+                location?: string;
+                type?: string;
+                name?: string;
             }>;
-            name: string;
+            name?: string;
         }>;
     };
 }
@@ -79,8 +79,9 @@ export async function runScan(context: vscode.ExtensionContext, binaryPath: stri
     loadingBar.text = "$(sync~spin) Scanning with Sysdig...";
     loadingBar.show();
 
-    childProcess.exec(command, { cwd: pathToScan, env: {SECURE_API_TOKEN: secureAPIToken} }, (error, stdout, stderr) => {
+    childProcess.exec(command, { cwd: pathToScan, env: {...process.env, SECURE_API_TOKEN: secureAPIToken} }, (error, stdout, stderr) => {
         loadingBar.hide();
+        outputChannel.appendLine(stdout);
         if (error) {
             console.error(`exec error: ${error}`);
             vscode.window.showErrorMessage(`Execution error: ${error}`);
@@ -122,11 +123,14 @@ function parseScanOutput(outputScanFile: string): { [key: string]: vscode.Diagno
         "low": vscode.DiagnosticSeverity.Information
     };
 
-    for (const finding of scanData.result.findings) {
-        const severity = severityMap[finding.severity.toLowerCase()];
-        for (const resource of finding.resources) {
+    for (const finding of scanData.result.findings ?? []) {
+        const severity = severityMap[finding.severity?.toLowerCase() ?? "low"];
+        for (const resource of finding.resources ?? []) {
             const message = finding.name + ": " + resource.location + " (" + resource.type + ": " + resource.name + ")";
             const diagnostic = new vscode.Diagnostic(new vscode.Range(0,0,0,0), message, severity);
+            if (!resource.source) {
+                continue;
+            }
             if (!diagnosticsMap[resource.source]) {
                 diagnosticsMap[resource.source] = [];
             }