Skip to content

🌱 Go Code Update (pre capi v1.11 (beta2))#1772

Merged
guettli merged 5 commits intov1.1.xfrom
tg/v1.1.x--go-updates
Jan 23, 2026
Merged

🌱 Go Code Update (pre capi v1.11 (beta2))#1772
guettli merged 5 commits intov1.1.xfrom
tg/v1.1.x--go-updates

Conversation

@guettli
Copy link
Copy Markdown
Collaborator

@guettli guettli commented Dec 19, 2025

This PR contains changes which were back-ported to v1.1.x (beta1, pre beta2)

Changes to tooling are in the next PR: #1771

Purpose: This PR updates Go code in the cluster-api-provider-hetzner repository in preparation for compatibility with the branch for ✨ v1.2.x with APIVersion v1beta2 by guettli · Pull Request #1760 · syself/cluster-api-provider-hetzner.

Changes:

  • Elaborate docs for HostReadyCondition
  • Use new hcloud server types (cpxN1 --> cpxN2)
  • Elaborate docs for InstallImage
  • Controller EnvTests: Show start of test, if DEBUG is set.
  • Fixed flaky unit-tests by waiting for HCloudBootStateOperatingSystemRunning
  • Fixed flaky unit-tests by wrapping Update() into a Eventually()
  • Removed not needed named return values (actionContinue Result())
  • Simplified code by using early-return (near if reflect.DeepEqual(oldHost, s.scope.HetznerBareMetalHost) {)
  • On conflict, requeueAfter 1s to avoid stale cache reads.
  • Fix error during delete hbmh (near msg := "server not found in Robot API during deprovisioning, assuming already removed")
  • show serverType and location if createServer fails (near msg := fmt.Sprintf("failed to create HCloud server %q in %q (type %q)",)
  • Set logLevel to Debug, when env var DEBUG is set.

@guettli guettli requested a review from janiskemper December 19, 2025 14:02
@github-actions github-actions Bot added size/L Denotes a PR that changes 200-800 lines, ignoring generated files. area/test Changes made in the test directory area/code Changes made in the code directory area/api Changes made in the api directory labels Dec 22, 2025
guettli added a commit that referenced this pull request Jan 21, 2026
Untested. First #1772 (Go Updates), then #1771 (Tooling Updates), then this PR.
@guettli guettli merged commit 25ebf3c into v1.1.x Jan 23, 2026
3 of 5 checks passed
@guettli guettli deleted the tg/v1.1.x--go-updates branch January 23, 2026 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/api Changes made in the api directory area/code Changes made in the code directory area/test Changes made in the test directory size/L Denotes a PR that changes 200-800 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants