🌱 test: use ConditionFalseWithReasonAtKey in controllers#1962
Open
🌱 test: use ConditionFalseWithReasonAtKey in controllers#1962
Conversation
github-actions
Bot
added
size/L
Contributor
Dhairya-Arora01
left a comment
Dhairya-Arora01
left a comment
There was a problem hiding this comment.
We should use ConditionFalseWithReasonAtKey func at other places like server_test.go as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use ConditionFalseWithReasonAtKey in controllers
In tests, the failure message of an Eventually() is usualy not easy to understand, when the function returns
bool. It is easier to understand, when the Eventually checks for the absencse of an error.