🌱 Implement image-url-command v2#2025
Open
guettli wants to merge 7 commits into
Open
Conversation
github-actions
Bot
added
size/L
Fix gci import alignment and return err instead of nil in StateOfImageURLCommandV2 error path. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Add top-level Status field to ImageURLCommandOutputV2. StateOfImageURLCommandV2 now treats a missing or unparseable Status as "not done yet" (requeue) instead of failing immediately — the binary writes output.json atomically so the file is either complete with a valid status or absent. Also pass --api-version flag to the binary via StartImageURLCommand's new apiVersion parameter. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…t.json When the process is gone (ps check fails) but output.json is missing or incomplete, return ImageURLCommandStateFailed right away instead of ImageURLCommandStateRunning. This prevents waiting up to 7 minutes for the timeout to fire when the binary crashed before writing its output. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Uses an in-process fake SSH server so the tests run without any external infrastructure. The two new failure-path tests would have caught the bug fixed in the previous commit: when the process has exited but output.json is missing or has no Status field, the old code returned ImageURLCommandStateRunning (waiting for the 7-minute timeout) instead of ImageURLCommandStateFailed (immediate termination). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Image URL Command v2: Better feedback from image-url-command to caph.
btw, I use
./hack/update-operator-dev-deployment.shto update the cluster. This installs the caph image from current code and updates the CRDs.