🌱 re-read hardwareDetails (backport #2096)#2183
Merged
Merged
Conversation
github-actions
Bot
added
size/M
janiskemper
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport of #2096 to
release-1.1.Always refresh
HardwareDetailsinactionRegisteringinstead of only setting it when nil. This means hardware changes (e.g. NIC replacement → new IP, disk exchange) are picked up automatically on re-registration without manual intervention.When the refreshed details differ from the previously stored ones, the controller logs a
"HardwareDetails changed"message with the diff and emits aHardwareDetails changedKubernetes event on theHetznerBareMetalHostobject, so the change is visible on the object itself, not just in the logs.Even if a hardware change makes the configured
RootDeviceHintsinvalid (e.g. the disk referenced by WWN was replaced), the freshly readHardwareDetailsis still persisted before that validation runs, so the object's status always reflects the current hardware.Fixes #1789