refactor(robot): align force-refresh naming

Author: guettli

hcloud/util.go

@@ -35,7 +35,7 @@ import (
 // youngRobotServerLookupWindow limits forced Robot refreshes to newly created nodes.
 var youngRobotServerLookupWindow = 10 * time.Minute
 
-type robotServerListFreshClient interface {
+type robotServerListForceRefreshClient interface {
 	ServerGetListForceRefresh() ([]models.Server, error)
 }
 
@@ -85,12 +85,12 @@ func getRobotServerByName(c robotclient.Client, node *corev1.Node) (server *mode
 		return server, nil
 	}
 
-	freshClient, ok := c.(robotServerListFreshClient)
+	forceRefreshClient, ok := c.(robotServerListForceRefreshClient)
 	if !ok {
 		return nil, nil
 	}
 
-	serverList, err = freshClient.ServerGetListForceRefresh()
+	serverList, err = forceRefreshClient.ServerGetListForceRefresh()
 	if err != nil {
 		hcops.HandleRateLimitExceededError(err, node)
 		return nil, fmt.Errorf("%s: refresh for young node: %w", op, err)

internal/robot/client/cache/client.go

@@ -148,7 +148,7 @@ func (c *cacheRobotClient) sync() ([]models.Server, error) {
 	// populate list
 	c.l = list
 
-	// remove all entries from map and populate it freshly
+	// remove all entries from map and repopulate it from the current list
 	c.m = make(map[int]*models.Server)
 	for i, server := range list {
 		c.m[server.ServerNumber] = &list[i]