[pull] master from ruby:master#111
Merged
pull[bot] merged 2 commits intosysfce2:masterfrom Dec 24, 2025
Merged
Conversation
Fixes #1523 The issue is likely caused by RDoc generating documentation using data from marshal load (used by `ri`), which has different types than if the generation happen directly. This code can reproduce the same error: ```rb require 'rdoc' require 'tmpdir' # Setup store options = RDoc::Options.new store = RDoc::Store.new(options, path: Dir.tmpdir) # Create a class with a comment tl = store.add_file 'file.rb' ns = tl.add_module RDoc::NormalModule, 'Namespace' cm = ns.add_class RDoc::NormalClass, 'Klass', 'Super' cm.add_comment 'This is a class comment', tl # Before marshalling - works fine puts "Before marshal: #{cm.search_snippet.inspect}" # Marshal round-trip (simulates loading from .ri cache) loaded = Marshal.load(Marshal.dump(cm)) loaded.store = store # After marshalling - fails with NoMethodError puts "After marshal: #{loaded.search_snippet.inspect}" ``` Similar to other code objects' marshalling behaviour, `ClassModule#comment_location`'s content type would change before/after marshalling. But it should still be an array of pairs that respond to the same set of methods. This commit also adds documentation about the marshalling behaviour of `ClassModule#comment_location`. I don't like the fact that data types & shapes could change before/after marshalling. But changing this design will be a breaking change and require some careful planning. So for now the change it to make sure the type change is less surprising
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )