Skip to content

[pull] master from ruby:master#140

Merged
pull[bot] merged 2 commits intosysfce2:masterfrom
ruby:master
Feb 9, 2026
Merged

[pull] master from ruby:master#140
pull[bot] merged 2 commits intosysfce2:masterfrom
ruby:master

Conversation

@pull
Copy link
Copy Markdown

@pull pull Bot commented Feb 9, 2026

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.4)

Can you help keep this open source service alive? 💖 Please sponsor : )

tompng and others added 2 commits February 9, 2026 20:41
…ck (#1595)

We need to ignore these within `Module.new do end` and any other block
because it might be a metaprogramming block.

Ignoring `def` `include` `extend` in a block is already implemented.
This pull request also make RDoc ignore visibility methods, attr
definition and module_function in a block.

```ruby
class A
  def f; end
  X = 1
  anonymous_module = Module.new do
    # These visibility change and attribute defition should be applied to anonymous module, but applied to A
    module_function :f
    private :f
    private_constant :X
    attr_accessor :rw
  end
end
```


Found while generating document in rails/rails

https://github.com/rails/rails/blob/45ee3bf84f20af55b8619b5dcc22a5e22a4ac0e7/activerecord/lib/active_record/connection_adapters/abstract/schema_definitions.rb#L307
```ruby
module ColumnMethods
  class_methods do
    private
    def m; end # This is a private method of unknown class/module
  end

  def g; end # This method should be public, but was treated as private and not documented
end
```
Decode legacy CGI-encoded labels (e.g., `What-27s+Here`) in rdoc-ref
links so they resolve to the correct GitHub-style anchors. Also
deduplicate heading IDs by appending -1, -2, etc. when multiple headings
produce the same anchor (e.g., "Method match" and "Method match?" both
becoming `method-match`).

Fixes #1590
@pull pull Bot locked and limited conversation to collaborators Feb 9, 2026
@pull pull Bot added the ⤵️ pull label Feb 9, 2026
@pull pull Bot merged commit 344cff2 into sysfce2:master Feb 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants