Skip to content

[pull] master from ruby:master#159

Merged
pull[bot] merged 2 commits intosysfce2:masterfrom
ruby:master
Mar 12, 2026
Merged

[pull] master from ruby:master#159
pull[bot] merged 2 commits intosysfce2:masterfrom
ruby:master

Conversation

@pull
Copy link
Copy Markdown

@pull pull Bot commented Mar 12, 2026

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.4)

Can you help keep this open source service alive? 💖 Please sponsor : )

st0012 and others added 2 commits March 13, 2026 04:56
## Summary

- Remove `RDoc::AnonClass` class and file (documented as "never used")
- Remove `Darkfish::VERSION` (unreferenced)
- Remove `Formatter::InlineTag` struct (unused after inline parser
rewrite)
- Remove `ToHtmlCrossref::CLASS_REGEXP_STR` and `METHOD_REGEXP_STR`
(aliased but unused within the file)

### Process & tools used

1. **Detect candidates** — Used `detect_dead_constants` from
[Rubydex](https://github.com/Shopify/rubydex) to find constants with
zero resolved references in `lib/`. Got 22 candidates.
2. **Filter out false positives** — Grepped for actual usage of each
candidate, catching private constants used internally, dynamic access
via `const_defined?`/`const_get`, default parameters, and generated code
(Racc).
3. **Remove confirmed dead code** — Deleted 5 constants and 1
class+file.
4. **Run full test suite** — Caught that one deletion (`RI::Formatter`)
broke a `require_relative` in `ri/driver.rb`, so restored it. Final run:
2384 tests, 0 failures.
The section expects a non-formatted comment.
Closes #1638

Can be simplified once the ripper parser is removed. It currently passes
the comment text as is and transforms it in the section class itself.
The prism parser now does it outside of that class.
@pull pull Bot locked and limited conversation to collaborators Mar 12, 2026
@pull pull Bot added the ⤵️ pull label Mar 12, 2026
@pull pull Bot merged commit d7d58e6 into sysfce2:master Mar 12, 2026
5 of 8 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants