[pull] master from ruby:master#174
Merged
pull[bot] merged 2 commits intosysfce2:masterfrom Apr 11, 2026
Merged
Conversation
## Summary - Fixes broken sidebar links when class aliases chain through other aliases (e.g., `HTTPRequestURITooLarge = HTTPRequestURITooLong = HTTPURITooLong` in `net/http`) - The outermost alias's sidebar link pointed to the intermediate alias's HTML file, which is never generated since aliases don't get their own pages - Resolve the alias chain in `update_aliases` by looking up the current store entry to follow already-processed aliases back to the real class - Also make `name_for_path` follow the chain recursively as a defensive measure Fixes #1664
## Summary When `#name` doesn't resolve to a method, the cross-reference handler was stripping the `#` and returning just the name. Now the original text including `#` is restored when the lookup fails. This fixes rendering of text like `#no-space-heading` in Markdown paragraphs, where the `#` was silently dropped in the final HTML. ### Refactoring - `cross_reference` no longer mutates its `name` parameter; uses a separate `display` variable for `#`-stripped text - `link` returns `nil` for unresolved references instead of returning bare text, letting the caller decide what to display - Label handling is hoisted out of the `case` branches so it's shared between resolved refs and bare label references (`@foo`) - Move new test methods before `private` helper section to follow file convention Found while investigating blockquote lazy continuation in #1627 — `#text` (not a valid heading) inside a blockquote was rendered without the `#`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )