Conversation
This replaces global in_syscall_context flag with per-task tracking in TCB. Global flag was corrupted when Task A yielded during syscall and Task B ran another syscall, clearing the flag before Task A resumed. - Add volatile bool in_syscall to tcb_t (survives preemption) - Update do_syscall to track per-task context - Update mo_task_spawn_kernel to check per-task flag - Use uintptr_t for syscall arguments (matches RISC-V ABI semantics)
Linmo CI Test ResultsOverall Status: ✅ passed Toolchain Results
Application Tests
Functional Test Details
Report generated from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces global in_syscall_context flag with per-task tracking in TCB. Global flag was corrupted when Task A yielded during syscall and Task B ran another syscall, clearing the flag before Task A resumed.
Summary by cubic
Fix a race in syscall context tracking by moving from a global flag to per-task tracking, ensuring correct privilege enforcement across preemption. Also switch syscall argument types to uintptr_t to match the RISC-V ABI.
Bug Fixes
Refactors
Written for commit bb6344f. Summary will update on new commits.